[DM-21525] Compiler warning about catching polymorphic exceptions by value - Jira

XML

Word

Printable

Details

Type: Improvement
Status: Done
Resolution: Done
Fix Version/s: None
Component/s: afw, cpputils, daf_base
Labels:
None

Story Points:
0.5
Epic Link:
s23b-ap-infrastructure
Team:
Architecture

Description

Starting with devtoolset-8, gcc-8 warns about catching polymorphic exceptions by value. As far as I understand, this is a bad coding practice in general.

The occurrence I've checked regarding ip_diffim build in afw/math/Statistics.h:115 is harmless, and I'll change it as part of ~~DM-21422~~.

A list of places to check are grepped and attached.

http://ptgmedia.pearsoncmg.com/images/0321113586/items/sutter_item73.pdf

In file included from /software/lsstsw/stack_20191001/stack/miniconda3-4.5.12-1172c30/Linux64/afw/18.1.0-17-gd2166b6e4/include/lsst/afw/math/Background.h:34,

 from /software/lsstsw/stack_20191001/stack/miniconda3-4.5.12-1172c30/Linux64/afw/18.1.0-17-gd2166b6e4/include/lsst/afw/math.h:33,

 from examples/maskedKernel.cc:2:

 /software/lsstsw/stack_20191001/stack/miniconda3-4.5.12-1172c30/Linux64/afw/18.1.0-17-gd2166b6e4/include/lsst/afw/math/Statistics.h: In constructor 'lsst::afw::math::StatisticsControl::StatisticsControl(double, int, lsst::afw::image::MaskPixel, bool, lsst::afw::math::StatisticsControl::WeightsBoolean)':

 /software/lsstsw/stack_20191001/stack/miniconda3-4.5.12-1172c30/Linux64/afw/18.1.0-17-gd2166b6e4/include/lsst/afw/math/Statistics.h:115:41: warning: catching polymorphic type 'class lsst::pex::exceptions::InvalidParameterError' by value [-Wcatch-value=]

 } catch (lsst::pex::exceptions::InvalidParameterError) \{

 ^~~~~~~~~~~~~~~~~~~~~

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

stack_20191001_catch_files.txt
15 kB
04/Oct/19 8:45 PM
sutter_item73.pdf
115 kB
04/Oct/19 10:54 PM

Issue Links

relates to

DM-21422 Fix ip_diffim mosaic debug plots broken by Mosaic.makeMosaic signature change and compiler warning

Done

Activity

Ascending order - Click to sort in descending order

No builds found.

Gabor Kovacs [X] (Inactive) created issue - 04/Oct/19 8:45 PM

Gabor Kovacs [X] (Inactive) made changes - 04/Oct/19 8:45 PM

Field	Original Value	New Value
Attachment		stack_20191001_catch_files.txt [ 40478 ]
Attachment		stack_20191001_catch.txt [ 40479 ]

Gabor Kovacs [X] (Inactive) made changes - 04/Oct/19 8:46 PM

Attachment

stack_20191001_catch.txt [ 40479 ]

Gabor Kovacs [X] (Inactive) made changes - 04/Oct/19 10:54 PM

Attachment

sutter_item73.pdf [ 40481 ]

Gabor Kovacs [X] (Inactive) made changes - 07/Oct/19 7:50 PM

Link

This issue relates to ~~DM-21422~~ [ ~~DM-21422~~ ]

Gabor Kovacs [X] (Inactive) made changes - 07/Oct/19 10:37 PM

Component/s		pex_policy [ 13620 ]
Component/s		utils [ 10723 ]

John Swinbank made changes - 15/Oct/19 12:38 AM

Labels

PairCoding

John Swinbank made changes - 15/Oct/19 12:38 AM

Description

Starting with devtoolset-8, gcc-8 warns about catching polymorphic exceptions by value. As far as I understand, this is a bad coding practice in general.

The occurrence I've checked regarding ip_diffim build in afw/math/Statistics.h:115 is harmless, and I'll change it as part of ~~DM-21422~~.

A list of places to check are grepped and attached.

[http://ptgmedia.pearsoncmg.com/images/0321113586/items/sutter_item73.pdf]

{quote}In file included from /software/lsstsw/stack_20191001/stack/miniconda3-4.5.12-1172c30/Linux64/afw/18.1.0-17-gd2166b6e4/include/lsst/afw/math/Background.h:34,
from /software/lsstsw/stack_20191001/stack/miniconda3-4.5.12-1172c30/Linux64/afw/18.1.0-17-gd2166b6e4/include/lsst/afw/math.h:33,
from examples/maskedKernel.cc:2:
/software/lsstsw/stack_20191001/stack/miniconda3-4.5.12-1172c30/Linux64/afw/18.1.0-17-gd2166b6e4/include/lsst/afw/math/Statistics.h: In constructor 'lsst::afw::math::StatisticsControl::StatisticsControl(double, int, lsst::afw::image::MaskPixel, bool, lsst::afw::math::StatisticsControl::WeightsBoolean)':
/software/lsstsw/stack_20191001/stack/miniconda3-4.5.12-1172c30/Linux64/afw/18.1.0-17-gd2166b6e4/include/lsst/afw/math/Statistics.h:115:41: warning: catching polymorphic type 'class lsst::pex::exceptions::InvalidParameterError' by value [-Wcatch-value=]
} catch (lsst::pex::exceptions::InvalidParameterError) \{
^~~~~~~~~~~~~~~~~~~~~
{quote}

Starting with devtoolset-8, gcc-8 warns about catching polymorphic exceptions by value. As far as I understand, this is a bad coding practice in general.

The occurrence I've checked regarding ip_diffim build in afw/math/Statistics.h:115 is harmless, and I'll change it as part of ~~DM-21422~~.

A list of places to check are grepped and attached.

[http://ptgmedia.pearsoncmg.com/images/0321113586/items/sutter_item73.pdf]

{code}
In file included from /software/lsstsw/stack_20191001/stack/miniconda3-4.5.12-1172c30/Linux64/afw/18.1.0-17-gd2166b6e4/include/lsst/afw/math/Background.h:34,
from /software/lsstsw/stack_20191001/stack/miniconda3-4.5.12-1172c30/Linux64/afw/18.1.0-17-gd2166b6e4/include/lsst/afw/math.h:33,
from examples/maskedKernel.cc:2:
/software/lsstsw/stack_20191001/stack/miniconda3-4.5.12-1172c30/Linux64/afw/18.1.0-17-gd2166b6e4/include/lsst/afw/math/Statistics.h: In constructor 'lsst::afw::math::StatisticsControl::StatisticsControl(double, int, lsst::afw::image::MaskPixel, bool, lsst::afw::math::StatisticsControl::WeightsBoolean)':
/software/lsstsw/stack_20191001/stack/miniconda3-4.5.12-1172c30/Linux64/afw/18.1.0-17-gd2166b6e4/include/lsst/afw/math/Statistics.h:115:41: warning: catching polymorphic type 'class lsst::pex::exceptions::InvalidParameterError' by value [-Wcatch-value=]
} catch (lsst::pex::exceptions::InvalidParameterError) \{
^~~~~~~~~~~~~~~~~~~~~
{code}

John Swinbank made changes - 15/Oct/19 12:39 AM

Story Points

John Swinbank made changes - 15/Oct/19 1:00 AM

Epic Link

~~DM-21441~~ [ 423048 ]

John Swinbank made changes - 15/Oct/19 1:00 AM

Team

Alert Production [ 10300 ]

John Swinbank made changes - 15/Oct/19 1:00 AM

Story Points

John Swinbank made changes - 14/Dec/19 11:25 PM

Epic Link

~~DM-21441~~ [ 423048 ]

~~DM-22484~~ [ 427311 ]

John Swinbank made changes - 03/Apr/20 10:56 PM

Epic Link

~~DM-22484~~ [ 427311 ]

~~DM-24339~~ [ 433026 ]

John Swinbank made changes - 17/Jun/20 9:56 PM

Epic Link

~~DM-24339~~ [ 433026 ]

~~DM-25139~~ [ 435257 ]

John Swinbank made changes - 21/Sep/20 5:22 PM

Epic Link

~~DM-25139~~ [ 435257 ]

~~DM-26810~~ [ 439762 ]

Ian Sullivan made changes - 08/Dec/20 4:33 AM

Epic Link

~~DM-26810~~ [ 439762 ]

~~DM-27906~~ [ 442554 ]

Ian Sullivan made changes - 12/Mar/21 9:37 PM

Epic Link

~~DM-27906~~ [ 442554 ]

~~DM-29214~~ [ 459218 ]

Ian Sullivan made changes - 01/Jun/21 5:31 PM

Epic Link

~~DM-29214~~ [ 459218 ]

~~DM-30436~~ [ 504824 ]

Ian Sullivan made changes - 07/Sep/21 10:23 PM

Epic Link

~~DM-30436~~ [ 504824 ]

~~DM-30501~~ [ 510159 ]

Ian Sullivan made changes - 30/Nov/21 11:04 PM

Epic Link

~~DM-30501~~ [ 510159 ]

~~DM-30502~~ [ 510160 ]

Ian Sullivan made changes - 09/Mar/22 11:54 PM

Epic Link

~~DM-30502~~ [ 510160 ]

~~DM-30506~~ [ 510172 ]

Nikolina Horvat made changes - 14/Jun/22 6:36 PM

Epic Link

~~DM-30506~~ [ 510172 ]

~~DM-34931~~ [ 1598492 ]

Ian Sullivan made changes - 22/Sep/22 8:06 PM

Epic Link

~~DM-34931~~ [ 1598492 ]

~~DM-36006~~ [ 1997396 ]

Ian Sullivan made changes - 08/Dec/22 12:49 AM

Epic Link

~~DM-36006~~ [ 1997396 ]

~~DM-36522~~ [ 2254239 ]

Ian Sullivan made changes - 07/Mar/23 1:42 AM

Epic Link

~~DM-36522~~ [ 2254239 ]

DM-36523 [ 2254240 ]

Tim Jenness made changes - 22/May/23 8:13 PM

Component/s		cpputils [ 20722 ]
Component/s	pex_policy [ 13620 ]
Component/s	utils [ 10723 ]

Hide

Permalink

Tim Jenness added a comment - 22/May/23 8:14 PM

Jim Bosch I have no idea if this is still an afw compiler problem.

Show

Tim Jenness added a comment - 22/May/23 8:14 PM Jim Bosch I have no idea if this is still an afw compiler problem.

Hide

Permalink

Jim Bosch added a comment - 23/May/23 2:23 PM

This is not a compiler problem; the compiler is right to complain, though it's not usually a critical problem (I'd put it at about the same level as using a mutable container as a default argument in Python). I haven't seen instances of this myself, but if Gabor grepped for them it's probably worth keeping that list and fixing them.

Matthias Wittgen, is this something your clang-tidy sweeps might have already taken care of for us?

Show

Jim Bosch added a comment - 23/May/23 2:23 PM This is not a compiler problem; the compiler is right to complain, though it's not usually a critical problem (I'd put it at about the same level as using a mutable container as a default argument in Python). I haven't seen instances of this myself, but if Gabor grepped for them it's probably worth keeping that list and fixing them. Matthias Wittgen , is this something your clang-tidy sweeps might have already taken care of for us?

Hide

Permalink

Matthias Wittgen added a comment - 23/May/23 2:28 PM

Yes. We can do one more clang-tidy run on the C++ code base and close this ticket.

Show

Matthias Wittgen added a comment - 23/May/23 2:28 PM Yes. We can do one more clang-tidy run on the C++ code base and close this ticket.

Matthias Wittgen made changes - 23/May/23 2:28 PM

Assignee

Matthias Wittgen [ wittgen ]

Matthias Wittgen made changes - 23/May/23 10:06 PM

Status

To Do [ 10001 ]

In Progress [ 3 ]

Hide

Permalink

Matthias Wittgen added a comment - 23/May/23 10:07 PM - edited

Compiling the stack with -Werror=catch-value passed. Closing this ticket as done.

Show

Matthias Wittgen added a comment - 23/May/23 10:07 PM - edited Compiling the stack with -Werror=catch-value passed. Closing this ticket as done.

Matthias Wittgen made changes - 23/May/23 10:08 PM

Status

In Progress [ 3 ]

In Review [ 10004 ]

Matthias Wittgen made changes - 23/May/23 10:08 PM

Status

In Review [ 10004 ]

Reviewed [ 10101 ]

Matthias Wittgen made changes - 23/May/23 10:08 PM

Resolution		Done [ 10000 ]
Status	Reviewed [ 10101 ]	Done [ 10002 ]

Matthias Wittgen made changes - 23/May/23 10:10 PM

Story Points	2	0.5
Team	Alert Production [ 10300 ]	Architecture [ 10304 ]
Watchers	Gabor Kovacs [X], Jim Bosch, Matthias Wittgen, Tim Jenness [ Gabor Kovacs [X], Jim Bosch, Matthias Wittgen, Tim Jenness ]	Jim Bosch, Matthias Wittgen, Tim Jenness [ Jim Bosch, Matthias Wittgen, Tim Jenness ]
Labels	PairCoding

People

Assignee:: Matthias Wittgen

Reporter:: Gabor Kovacs [X] (Inactive)

Watchers:: Jim Bosch, Matthias Wittgen, Tim Jenness

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 04/Oct/19 8:45 PM

Updated:: 23/May/23 10:10 PM

Resolved:: 23/May/23 10:08 PM

Jenkins

No builds found.

Data Management

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Jenkins