Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-21707

templates CI strategy does not detect untracked files

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: templates
    • Labels:
      None

      Description

      The technote_aastex template's example has an untracked file. The CI script for lsst/templates is supposed to detect and dirty state in the Git repo when the examples are regenerated in CI. File diffs are detected, but evidently untracked files are not.

      It seems that this is the best way to detect untracked files: https://stackoverflow.com/a/2659808

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          jsick Jonathan Sick added a comment -

          The problem with using git ls-files --others is that it's detecting .sconsign.dblite, which should be an ignored file.

          Show
          jsick Jonathan Sick added a comment - The problem with using git ls-files --others is that it's detecting .sconsign.dblite , which should be an ignored file.
          Hide
          Permalink
          jsick Jonathan Sick added a comment -

          Perhaps a "smarter" test step needs to be added to templatekit itself, coded with GitPython to detect a dirty state.

          Show
          jsick Jonathan Sick added a comment - Perhaps a "smarter" test step needs to be added to templatekit itself, coded with GitPython to detect a dirty state.
          Hide
          Permalink
          jsick Jonathan Sick added a comment - - edited

          Released templatekit 0.4.0: https://github.com/lsst-sqre/templatekit/pull/10 which features a new templatekit check command to perform the validation.

          Show
          jsick Jonathan Sick added a comment - - edited Released templatekit 0.4.0: https://github.com/lsst-sqre/templatekit/pull/10 which features a new templatekit check command to perform the validation.
          Hide
          Permalink
          jsick Jonathan Sick added a comment -

          Deployed the new templatekit check command in the templates repo: https://github.com/lsst/templates/pull/51

          Show
          jsick Jonathan Sick added a comment - Deployed the new templatekit check command in the templates repo: https://github.com/lsst/templates/pull/51

            People

            Assignee:
            jsick Jonathan Sick
            Reporter:
            jsick Jonathan Sick
            Watchers:
            Jonathan Sick
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.