Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-2178

Migrate Qserv to external sphgeom

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Qserv, sphgeom
    • Labels:
      None

      Description

      Migrating qserv to the new c++ geometry API required porting a fair amount of code from the python layer and updating the plumbing in the czar. During implementation, the sphgeom was in the process of finding a home, so the sg code was temporarily placed under core/modules.

      This ticket covers:

      • removing core/modules/sg
      • updating code to point at the external sphgeom
      • updating build-logic to properly depend on and link with external sphgeom.

        Attachments

          Issue Links

            Activity

            Hide
            smonkewitz Serge Monkewitz added a comment -

            Since I think you both know the most about the build system / distribution tooling, I've assigned this one to both you. This ticket removes the sg core module in favor of an external dependency (sphgeom). What I have so far builds, passes unit tests, and passes integration tests in mono-node.

            Note that as it stands, once I merge this to master, others will have to checkout master of sphgeom to build qserv. Presumably I should also get sphgeom up on the distribution server and modify the eups definition of qserv_distrib as well, but I don't know how to do any of that.

            Show
            smonkewitz Serge Monkewitz added a comment - Since I think you both know the most about the build system / distribution tooling, I've assigned this one to both you. This ticket removes the sg core module in favor of an external dependency (sphgeom). What I have so far builds, passes unit tests, and passes integration tests in mono-node. Note that as it stands, once I merge this to master, others will have to checkout master of sphgeom to build qserv. Presumably I should also get sphgeom up on the distribution server and modify the eups definition of qserv_distrib as well, but I don't know how to do any of that.
            Hide
            tjenness Tim Jenness added a comment -

            If you add sphgeom as a dependency of qserv in the table file there is no need to also add it to qserv_distrib. The next time Qserv is published sphgeom will also be published.

            Show
            tjenness Tim Jenness added a comment - If you add sphgeom as a dependency of qserv in the table file there is no need to also add it to qserv_distrib . The next time Qserv is published sphgeom will also be published.
            Hide
            salnikov Andy Salnikov added a comment -

            Serge, looks OK, no comments. Removing myself from reviewers.

            Show
            salnikov Andy Salnikov added a comment - Serge, looks OK, no comments. Removing myself from reviewers.
            Hide
            jammes Fabrice Jammes added a comment -

            Nice job, no comments.

            Show
            jammes Fabrice Jammes added a comment - Nice job, no comments.
            Hide
            smonkewitz Serge Monkewitz added a comment -

            Merged in b3e3e79

            Show
            smonkewitz Serge Monkewitz added a comment - Merged in b3e3e79

              People

              • Assignee:
                smonkewitz Serge Monkewitz
                Reporter:
                fritzm Fritz Mueller
                Reviewers:
                Fabrice Jammes
                Watchers:
                Andy Salnikov, Fabrice Jammes, Serge Monkewitz, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel