Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-21899

Remove pytest EUPS package

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Pytest is provided by the Conda environment. But we're also carrying an (older) version as an EUPS package, and it's causing problems. Drop it.

        Attachments

          Activity

          Hide
          swinbank John Swinbank added a comment -

          Changes on this ticket:

          • Updated the version of pytest supplied in the scipipe_conda_env.
          • Added pytest-cov and pytest-xdist to the scipipe_conda_env. This also pulls in pytest-forked and execnet as dependencies.
          • Reverted all the changes to scipipe_conda_env from DM-21746 (see that ticket for a discussion).
          • Dropped dependencies on pytest (-cov, -xdist, etc) from EUPS table files.
          • Modified sconsUtils to not run a flake8 test on pytest. See the commit message for discussion; basically, pytest will try to import anything it checks, and sconsUtils is deliberately not-importable.
          Show
          swinbank John Swinbank added a comment - Changes on this ticket: Updated the version of pytest supplied in the scipipe_conda_env. Added pytest-cov and pytest-xdist to the scipipe_conda_env. This also pulls in pytest-forked and execnet as dependencies. Reverted all the changes to scipipe_conda_env from DM-21746 (see that ticket for a discussion). Dropped dependencies on pytest (-cov, -xdist, etc) from EUPS table files. Modified sconsUtils to not run a flake8 test on pytest. See the commit message for discussion; basically, pytest will try to import anything it checks, and sconsUtils is deliberately not-importable.
          Hide
          swinbank John Swinbank added a comment -

          Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30635/pipeline

          Note that centos-7.devtoolset-8.py3 appears to have bugged out after successfully building; given time pressure, I don't intend to repeat the build.

          Show
          swinbank John Swinbank added a comment - Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30635/pipeline Note that centos-7.devtoolset-8.py3 appears to have bugged out after successfully building; given time pressure, I don't intend to repeat the build.
          Show
          swinbank John Swinbank added a comment - Following this ticket merging, I believe we need to update the following to the SHA of the merge commit: https://github.com/lsst-dm/jenkins-dm-jobs/blob/master/etc/scipipe/build_matrix.yaml#L8 https://github.com/lsst/lsst/blob/master/scripts/newinstall.sh#L36 https://github.com/lsst/lsstsw/blob/master/bin/deploy#L23
          Hide
          swinbank John Swinbank added a comment -

          Also, we should shift the pytest packages which are no longer included in the build to lsst-dm "legacy" repositories.

          Show
          swinbank John Swinbank added a comment - Also, we should shift the pytest packages which are no longer included in the build to lsst-dm "legacy" repositories.
          Show
          swinbank John Swinbank added a comment - PRs: https://github.com/lsst/scipipe_conda_env/pull/6 https://github.com/lsst/pytest_xdist/pull/6 https://github.com/lsst/pytest_session2file/pull/1 https://github.com/lsst/pytest_cov/pull/1 https://github.com/lsst/pytest_flake8/pull/6 https://github.com/lsst/sconsUtils/pull/73 https://github.com/lsst/pytest_forked/pull/5 https://github.com/lsst/python_mccabe/pull/1
          Hide
          swinbank John Swinbank added a comment -

          Hey Tim Jenness, would you mind taking a look at this please?

          Show
          swinbank John Swinbank added a comment - Hey Tim Jenness , would you mind taking a look at this please?
          Hide
          tjenness Tim Jenness added a comment -

          These look fine. When the conda env is updated to newer versions we will clearly have to check the status of our remaining eups pytest packages. I think we can assume that lsst_sims will be fine as well (we would normally test it when doing a full conda env refresh).

          Show
          tjenness Tim Jenness added a comment - These look fine. When the conda env is updated to newer versions we will clearly have to check the status of our remaining eups pytest packages. I think we can assume that lsst_sims will be fine as well (we would normally test it when doing a full conda env refresh).
          Hide
          swinbank John Swinbank added a comment -

          Thanks for the quick review. Merged and done. Let's hope that Jenkins is now happy...

          Show
          swinbank John Swinbank added a comment - Thanks for the quick review. Merged and done. Let's hope that Jenkins is now happy...

            People

            Assignee:
            swinbank John Swinbank
            Reporter:
            swinbank John Swinbank
            Reviewers:
            Tim Jenness
            Watchers:
            John Swinbank, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins Builds

                No builds found.