Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-21910

Move lsst.verify.gen2tasks.MetricTask to lsst.verify.tasks

    Details

      Description

      The migration plan alluded to in DMTN-098, and researched in DM-16503, involved creating separate Gen 2 and Gen 3 MetricTasks. This plan was motivated by the assumption that metrics would be in wide use by the time of the migration, making writing a class adapter for each and every metric impractical. However, MetricTask has seen limited uptake, making the careful approach unnecessary.

      The new plan is to follow the process the Middleware group has been using, and retrofit Gen 3 functionality onto MetricTask directly. The only loose end is the current use of gen2tasks.MetricTask.

      Move gen2tasks.MetricTask to tasks.MetricTask, keeping the old name as a deprecated alias (much as we did when we created the new geom package from afw.geom). Update known MetricTasks to use the new name immediately.

        Attachments

          Issue Links

            Activity

            Hide
            krzys Krzysztof Findeisen added a comment -

            Hi Ian Sullivan, would you be willing to review this? It's formally 430 lines, but about half of that is cut-and-pasting code, and the rest is mechanical substitutions.

            The metrics in ap_association did not need to be modified, because none of them inherit directly from MetricTask.

            Show
            krzys Krzysztof Findeisen added a comment - Hi Ian Sullivan , would you be willing to review this? It's formally 430 lines, but about half of that is cut-and-pasting code, and the rest is mechanical substitutions. The metrics in ap_association did not need to be modified, because none of them inherit directly from MetricTask .
            Hide
            sullivan Ian Sullivan added a comment -

            Looks good. I left a couple of fairly minor comments on the pull requests.

            Show
            sullivan Ian Sullivan added a comment - Looks good. I left a couple of fairly minor comments on the pull requests.

              People

              • Assignee:
                krzys Krzysztof Findeisen
                Reporter:
                krzys Krzysztof Findeisen
                Reviewers:
                Ian Sullivan
                Watchers:
                Ian Sullivan, Krzysztof Findeisen
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel