Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-21911

Retrofit Gen 3 functionality onto MetricTask

    Details

      Description

      MetricTask is a Gen 2 task that provides a non-dataref abstract run method, as well as some functionality needed to read Gen 3 input specifications without access to a Gen 3 repository. As such, it should be possible to add PipelineTask functionality using the standard procedure developed for CmdLineTask.

      Story points are a guess; I'm not clear what needs to be done besides adding a Connections class for the Measurement output. MetricTask should use the default runQuantum method, although at least one subclass will need to override it (DM-21912).

      The existing Gen 2 methods like MetricTask.areInputDatasetsScalar should not be deprecated until Gen 2 itself is.

        Attachments

          Issue Links

            Activity

            Hide
            krzys Krzysztof Findeisen added a comment -

            MetricTask should have a runQuantum that handles unusual conditions in run; see DM-21937 for more details.

            Show
            krzys Krzysztof Findeisen added a comment - MetricTask should have a runQuantum that handles unusual conditions in run ; see DM-21937 for more details.
            Hide
            krzys Krzysztof Findeisen added a comment -

            Hi Nate Lust, would you be willing to review this 460-line change? As before, subclassing means I'm using a couple of Gen 3 features in weird ways, so I'd like to make sure I'm not breaking anything.

            Show
            krzys Krzysztof Findeisen added a comment - Hi Nate Lust , would you be willing to review this 460-line change? As before, subclassing means I'm using a couple of Gen 3 features in weird ways, so I'd like to make sure I'm not breaking anything.
            Hide
            nlust Nate Lust added a comment -

            Overall I am very happy with how well this all came together. There are a few minor points to consider and or discuss, but I think it is good.

            Show
            nlust Nate Lust added a comment - Overall I am very happy with how well this all came together. There are a few minor points to consider and or discuss, but I think it is good.

              People

              • Assignee:
                krzys Krzysztof Findeisen
                Reporter:
                krzys Krzysztof Findeisen
                Reviewers:
                Nate Lust
                Watchers:
                Krzysztof Findeisen, Nate Lust
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel