Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-21920

Try out and write notebook about demonstrating basic DFT space steps for ip_diffim operations

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Try out DFT space operations to understand:

      • How to properly do convolution in DFT space in image and PSF kernel relation
      • Padding, borders, translation of originals
      • Numeric optimization of DFT, IDFT transformations by shifting significant values into the high-frequency region.
      • Demonstrate a kernel inversion (deconvolution) operation, prototype how to do this in the decorrelation afterburner
      • Ian Sullivan's hint: Check whether the above works for odd size FFT calls because odd size handling in DFT may be implementation dependent.

      Write this in a jupyter notebook.

        Attachments

          Issue Links

            Activity

            No builds found.
            gkovacs Gabor Kovacs [X] (Inactive) created issue -
            gkovacs Gabor Kovacs [X] (Inactive) made changes -
            Field Original Value New Value
            Link This issue relates to DM-21868 [ DM-21868 ]
            gkovacs Gabor Kovacs [X] (Inactive) made changes -
            Link This issue relates to DM-21868 [ DM-21868 ]
            gkovacs Gabor Kovacs [X] (Inactive) made changes -
            Link This issue is child task of DM-21868 [ DM-21868 ]
            gkovacs Gabor Kovacs [X] (Inactive) made changes -
            Description Try out DFT space operations to understand:
             * How to properly do convolution in DFT space in image and PSF kernel relation
             * Padding, borders, translation of originals
             * Numeric optimization of DFT, IDFT transformations by shifting significant values into the high-frequency region.
             * Demonstrate a kernel inversion (deconvolution) operation, prototype how to do this in the decorrelation afterburner

            Write this in a jupyter notebook.
            Try out DFT space operations to understand:
             * How to properly do convolution in DFT space in image and PSF kernel relation
             * Padding, borders, translation of originals
             * Numeric optimization of DFT, IDFT transformations by shifting significant values into the high-frequency region.
             * Demonstrate a kernel inversion (deconvolution) operation, prototype how to do this in the decorrelation afterburner
             * [~sullivan]'s hint: Check whether the above works for odd size FFT calls because odd size handling in DFT may be implementation dependent.

            Write this in a jupyter notebook.
            Hide
            gkovacs Gabor Kovacs [X] (Inactive) added a comment -

            Based on  numpy fft docs and fftfrwq, in the odd case the highest frequency is less than 1/2.

            Show
            gkovacs Gabor Kovacs [X] (Inactive) added a comment - Based on  numpy fft docs and fftfrwq , in the odd case the highest frequency is less than 1/2.
            gkovacs Gabor Kovacs [X] (Inactive) made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            gkovacs Gabor Kovacs [X] (Inactive) added a comment -

            Would you please review the notebook I've shown ? l've added some comments. It's a PR in diffimTests.

            Show
            gkovacs Gabor Kovacs [X] (Inactive) added a comment - Would you please review the notebook I've shown ? l've added some comments. It's a PR in diffimTests.
            gkovacs Gabor Kovacs [X] (Inactive) made changes -
            Reviewers Ian Sullivan [ sullivan ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            gkovacs Gabor Kovacs [X] (Inactive) made changes -
            Link This issue relates to DM-21702 [ DM-21702 ]
            swinbank John Swinbank made changes -
            Epic Link DM-21444 [ 423051 ]
            swinbank John Swinbank made changes -
            Team Alert Production [ 10300 ]
            Hide
            sullivan Ian Sullivan added a comment -

            Just checking in that you saw the comments and change requests I left on the PR last week.

            Show
            sullivan Ian Sullivan added a comment - Just checking in that you saw the comments and change requests I left on the PR last week.
            gkovacs Gabor Kovacs [X] (Inactive) made changes -
            Status In Review [ 10004 ] In Progress [ 3 ]
            Hide
            gkovacs Gabor Kovacs [X] (Inactive) added a comment -

            I updated the notebook texts to address your comments.

            Show
            gkovacs Gabor Kovacs [X] (Inactive) added a comment - I updated the notebook texts to address your comments.
            gkovacs Gabor Kovacs [X] (Inactive) made changes -
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            sullivan Ian Sullivan added a comment -

            The updated notebook looks good. I had a couple of fairly minor comments on the pull request, but go ahead and merge and mark this 'Done' once you are happy with everything.

            Show
            sullivan Ian Sullivan added a comment - The updated notebook looks good. I had a couple of fairly minor comments on the pull request, but go ahead and merge and mark this 'Done' once you are happy with everything.
            sullivan Ian Sullivan made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            gkovacs Gabor Kovacs [X] (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            swinbank John Swinbank made changes -
            Story Points 8
            gkovacs Gabor Kovacs [X] (Inactive) made changes -
            Link This issue relates to DM-23855 [ DM-23855 ]

              People

              Assignee:
              gkovacs Gabor Kovacs [X] (Inactive)
              Reporter:
              gkovacs Gabor Kovacs [X] (Inactive)
              Reviewers:
              Ian Sullivan
              Watchers:
              Gabor Kovacs [X] (Inactive), Ian Sullivan
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.