Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-21957

Update AT packages to use ts_simactuators

    Details

    • Story Points:
      1
    • Sprint:
      TSSW Sprint - Oct 28 - Nov 10, TSSW Sprint - Nov 25 - Dec 6, TSSW Sprint - Dec 9 - Dec 20
    • Team:
      Telescope and Site

      Description

      Update packages that have simulated actuators to use ts_simactuators. These include:

      • ts_ATDome
      • ts_ATMCSSImulator

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment - - edited

            I also looked into making the ATMCS M3 actuator a point-to-point actuator but decided against it. The tracking actuator has somewhat more realistic motion and the code is simpler using the same actuator type for all axes.

            Pull requests:

            Show
            rowen Russell Owen added a comment - - edited I also looked into making the ATMCS M3 actuator a point-to-point actuator but decided against it. The tracking actuator has somewhat more realistic motion and the code is simpler using the same actuator type for all axes. Pull requests: https://github.com/lsst-ts/ts_ATDome/pull/16 https://github.com/lsst-ts/ts_ATMCSSimulator/pull/16
            Hide
            jlopezl Jorge Lopez (Inactive) added a comment -

            Both PRs reviewed in GitHub.

            Show
            jlopezl Jorge Lopez (Inactive) added a comment - Both PRs reviewed in GitHub.
            Hide
            rowen Russell Owen added a comment - - edited

            Thank you for the helpful renaming suggestions. I adopted all of them.

            Merged to develop and master and tagged both as v0.10.0 (though in retrospect I probably should have tagged ATDome as v1.0.0, but then I would have had to update the revision history). ATMCSSimulator is not ready to be released as v1 because we haven't finished refining the ATMCS API.

            Show
            rowen Russell Owen added a comment - - edited Thank you for the helpful renaming suggestions. I adopted all of them. Merged to develop and master and tagged both as v0.10.0 (though in retrospect I probably should have tagged ATDome as v1.0.0, but then I would have had to update the revision history). ATMCSSimulator is not ready to be released as v1 because we haven't finished refining the ATMCS API.

              People

              • Assignee:
                rowen Russell Owen
                Reporter:
                rowen Russell Owen
                Reviewers:
                Jorge Lopez (Inactive)
                Watchers:
                Jorge Lopez (Inactive), Russell Owen
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: