Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-21969

Replace simulated actuator in ts_rotator with a tracking actuator

    XMLWordPrintable

    Details

      Description

      ts_rotator's mock controller uses a point to point actuator to model the rotator. That is not a very good fit (though tolerable given the frequency of tracking updates).

      ts_simactuators includes TrackingActuator which is a much better model. Switch to that.

        Attachments

          Issue Links

          duplicates

          Improvement - An improvement or enhancement to an existing feature or task. DM-22645 Update ts_rotator to use use the TrackingActuator from ts_simactuators.

          • Won't Fix
          is triggered by

          Improvement - An improvement or enhancement to an existing feature or task. DM-21936 Make new package containing actuator simulators written in Python

          • Done

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            rowen Russell Owen created issue -
            rowen Russell Owen made changes -
            Field Original Value New Value
            Epic Link DM-21473 [ 424069 ]
            rowen Russell Owen made changes -
            Link This issue is triggered by DM-21936 [ DM-21936 ]
            rowen Russell Owen made changes -
            Labels ts_rotator
            aclements Andy Clements made changes -
            Epic Link DM-21473 [ 424069 ] DM-21931 [ 425242 ]
            ttsai Te-Wei Tsai made changes -
            Epic Link DM-21931 [ 425242 ] DM-23800 [ 431613 ]
            rowen Russell Owen made changes -
            Sprint TSSW Sprint - Apr 13 - Apr 27 [ 1012 ]
            rowen Russell Owen made changes -
            Link This issue duplicates DM-22645 [ DM-22645 ]
            rowen Russell Owen made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            Permalink
            rowen Russell Owen added a comment -

            In addition to switching to a tracking actuator, I also made the following changes:

            • Improved the tracking tests (first git commit).
            • Only start the tracking timeout timer in the mock controller after the first position, velocity, time track command is received. Formerly the timer started when entering tracking mode, which seems unnecessary. (I don't know what the real low level controller does.)
              Pull request: https://github.com/lsst-ts/ts_rotator/pull/10
            Show
            rowen Russell Owen added a comment - In addition to switching to a tracking actuator, I also made the following changes: Improved the tracking tests (first git commit). Only start the tracking timeout timer in the mock controller after the first position, velocity, time track command is received. Formerly the timer started when entering tracking mode, which seems unnecessary. (I don't know what the real low level controller does.) Pull request: https://github.com/lsst-ts/ts_rotator/pull/10
            rowen Russell Owen made changes -
            Description ts_rotator's mock controller uses a point to point actuator to model the rotator. That is not a very good fit (though tolerable given the frequency of tracking updates).

            ts_simactuators includes TrackingActuator which is a much better model. Switch to that.

            This requires a bit of work because the indicators for "in position" and tracking vs slewing are different. Also it may take some work to handle point to point motion.             		ts_rotator's mock controller uses a point to point actuator to model the rotator. That is not a very good fit (though tolerable given the frequency of tracking updates).

            ts_simactuators includes TrackingActuator which is a much better model. Switch to that.
            rowen Russell Owen made changes -
            Reviewers Te-Wei Tsai [ ttsai ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            Permalink
            ttsai Te-Wei Tsai added a comment -

            TrackingActuator is used to have a better simulation. Great job done!

            Show
            ttsai Te-Wei Tsai added a comment - TrackingActuator is used to have a better simulation. Great job done!
            ttsai Te-Wei Tsai made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            rowen Russell Owen made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Merged to develop and master and released as v0.4.0. Documentation uploaded to https://ts-rotator.lsst.io

            Show
            rowen Russell Owen added a comment - Merged to develop and master and released as v0.4.0. Documentation uploaded to https://ts-rotator.lsst.io

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Te-Wei Tsai
              Watchers:
              Russell Owen, Te-Wei Tsai
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.