Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-2200

eupspkg TaP packages cannot contain files like README.md

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: eups
    • Labels:
      None
    • Team:
      SQuaRE

      Description

      (Original problem discovered by Rahul Biswas)

      Now that the packages for external products are on GitHub, it would be nice for them to contain files like the near-standard "README.md". Unfortunately, eupspkg.sh's default_prep command explicitly inspects tarball-and-patch (TaP) packages to make sure there are no other files in the package root directory. I think this is a little excessive.

      There's a bypass if the environment variable TAP_PACKAGE is set, but the package's table file has not yet been setup, so it's not possible to set this variable there. (The comments for the default_prep command suggest that the dependencies have been setup, but it's not clear that this is necessarily the case if invoked by lsst-build.)

      I suggest that we check instead for a ./.tap_package file to indicate definitively that this is a TaP package.

        Attachments

          Activity

          Show
          ktl Kian-Tat Lim added a comment - https://github.com/RobertLuptonTheGood/eups/pull/36 was filed.
          Hide
          ktl Kian-Tat Lim added a comment -

          Pull request merged on GitHub.

          Show
          ktl Kian-Tat Lim added a comment - Pull request merged on GitHub.

            People

            Assignee:
            mjuric Mario Juric
            Reporter:
            ktl Kian-Tat Lim
            Reviewers:
            Mario Juric, Robert Lupton
            Watchers:
            Kian-Tat Lim, Mario Juric, Rahul Biswas, Robert Lupton
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins Builds

                No builds found.