Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-22039

Rename dax_ppdb to dax_apdb together with all dependencies

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: dax_ppdb
    • Labels:

      Description

      Implements RFC-642

        Attachments

          Issue Links

            Activity

            No builds found.
            salnikov Andy Salnikov created issue -
            salnikov Andy Salnikov made changes -
            Field Original Value New Value
            Link This issue is triggered by RFC-642 [ RFC-642 ]
            Hide
            krzys Krzysztof Findeisen added a comment - - edited

            Note that DM-21877 is adding a few more references to lsst.dax.ppdb.Ppdb to lsst.verify and the obs packages, so there will have to be a rebase between these two tickets.

            Show
            krzys Krzysztof Findeisen added a comment - - edited Note that DM-21877 is adding a few more references to lsst.dax.ppdb.Ppdb to lsst.verify and the obs packages, so there will have to be a rebase between these two tickets.
            krzys Krzysztof Findeisen made changes -
            Link This issue relates to DM-21877 [ DM-21877 ]
            salnikov Andy Salnikov made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            salnikov Andy Salnikov made changes -
            Remote Link This issue links to "Package renaming procedure (Web Link)" [ 22401 ]
            salnikov Andy Salnikov made changes -
            Link This issue is triggering DM-22196 [ DM-22196 ]
            Hide
            salnikov Andy Salnikov added a comment -

            Krzysztof Findeisen, I'm getting ready for sending bunch of PRs on this ticket for review but I'd prefer to wait until DM-21877 is merged if it's not too long. Do you know when that is going to happen?

            Show
            salnikov Andy Salnikov added a comment - Krzysztof Findeisen , I'm getting ready for sending bunch of PRs on this ticket for review but I'd prefer to wait until DM-21877 is merged if it's not too long. Do you know when that is going to happen?
            Hide
            krzys Krzysztof Findeisen added a comment -

            I'm not sure. Please don't wait on my account; it may be easier to do the rebase in the other direction, anyway.

            Show
            krzys Krzysztof Findeisen added a comment - I'm not sure. Please don't wait on my account; it may be easier to do the rebase in the other direction, anyway.
            Hide
            salnikov Andy Salnikov added a comment -

            I think this is ready for review, Jenkins built it successfully yesterday (https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30760/pipeline). There are total 7 packages touched with a lot of renaming in every one of them.

            I do not want to burden a single person with the review so I'm going to split it semi-randomly between Chris and Krzysztof, with notebooks left to Meredith:

            dax_apdb is still in lsst-dm at this point but it will be moved to a lsst org after review. All existing branches are preserved in the new repo at the time of fork, development should switch to new package once this renaming is finished.

            Show
            salnikov Andy Salnikov added a comment - I think this is ready for review, Jenkins built it successfully yesterday ( https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30760/pipeline ). There are total 7 packages touched with a lot of renaming in every one of them. I do not want to burden a single person with the review so I'm going to split it semi-randomly between Chris and Krzysztof, with notebooks left to Meredith: dax_ppdb , dax_apdb , ap_association - Chris Morrison [X] verify , ap_pipe , ap_verify - Krzysztof Findeisen ap_pipe-notebooks - Meredith Rawls dax_apdb is still in lsst-dm at this point but it will be moved to a lsst org after review. All existing branches are preserved in the new repo at the time of fork, development should switch to new package once this renaming is finished.
            salnikov Andy Salnikov made changes -
            Reviewers Chris Morrison, Krzysztof Findeisen, Meredith Rawls [ cmorrison, krzys, mrawls ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            krzys Krzysztof Findeisen added a comment - - edited

            I'm trying to test the changes, but setting up pipe_tasks or obs_decam causes me to set up dax_ppdb. This seems to be a quirk of how the weekly builds create their EUPS files (all dependencies rather than just direct ones); is this going to cause problems between ticket merge and the following weekly?

            Show
            krzys Krzysztof Findeisen added a comment - - edited I'm trying to test the changes, but setting up pipe_tasks or obs_decam causes me to set up dax_ppdb . This seems to be a quirk of how the weekly builds create their EUPS files (all dependencies rather than just direct ones); is this going to cause problems between ticket merge and the following weekly?
            Hide
            salnikov Andy Salnikov added a comment -

            Hmm, there is probably some other package pulling that dax_ppdb dependency that I missed, looking into it now.

            Show
            salnikov Andy Salnikov added a comment - Hmm, there is probably some other package pulling that dax_ppdb dependency that I missed, looking into it now.
            Hide
            salnikov Andy Salnikov added a comment -

            Krzysztof Findeisen, I think it's a usual eups quirk, table files in the release have all flatten dependencies in them at the time of the release. I do not know how to handle this correctly until the next weekly build, but there are two options:

            • clone pipe_tasks and setup it from local directory
            • say setup --inexact -k pipe_tasks (or ap_pipe) (after setting up locally cloned packages)
            Show
            salnikov Andy Salnikov added a comment - Krzysztof Findeisen , I think it's a usual eups quirk, table files in the release have all flatten dependencies in them at the time of the release. I do not know how to handle this correctly until the next weekly build, but there are two options: clone pipe_tasks and setup it from local directory say setup --inexact -k pipe_tasks (or ap_pipe) (after setting up locally cloned packages)
            Hide
            krzys Krzysztof Findeisen added a comment - - edited

            The repos assigned to me look good, aside from some incomplete replacements (especially of the full phrase "Prompt Products Database").

            Show
            krzys Krzysztof Findeisen added a comment - - edited The repos assigned to me look good, aside from some incomplete replacements (especially of the full phrase "Prompt Products Database").
            krzys Krzysztof Findeisen made changes -
            Reviewers Chris Morrison, Krzysztof Findeisen, Meredith Rawls [ cmorrison, krzys, mrawls ] Chris Morrison, Meredith Rawls [ cmorrison, mrawls ]
            Hide
            salnikov Andy Salnikov added a comment - - edited

            Found one more dependency. Jonathan Sick, could you check pipelines_lsst_io PR? It's one line change that I know should work, but I do not know how to test that.

            Show
            salnikov Andy Salnikov added a comment - - edited Found one more dependency. Jonathan Sick , could you check pipelines_lsst_io PR? It's one line change that I know should work, but I do not know how to test that.
            salnikov Andy Salnikov made changes -
            Reviewers Chris Morrison, Meredith Rawls [ cmorrison, mrawls ] Chris Morrison, Jonathan Sick, Meredith Rawls [ cmorrison, jsick, mrawls ]
            Hide
            jsick Jonathan Sick added a comment -

            Andy Salnikov make sure you update the doc directory at the same time; particularly the content of manifest.yaml and the name of the lsst.dax.ppdb" directory.

            Show
            jsick Jonathan Sick added a comment - Andy Salnikov make sure you update the doc directory at the same time; particularly the content of manifest.yaml and the name of the lsst.dax.ppdb " directory. https://github.com/lsst-dm/dax_apdb/blob/master/doc/manifest.yaml https://github.com/lsst-dm/dax_apdb/tree/master/doc
            jsick Jonathan Sick made changes -
            Comment [ [~salnikov] that looks good. Feel free to merge; we'll find out with the daily documentation build. ]
            Hide
            salnikov Andy Salnikov added a comment -

            Jonathan Sick, thanks for catching that, actually manifest was already OK, but I forgot to rename doc/lsst.dax.ppdb. Everything should be OK on a branch now, and I will need to merge all branches at the same time.

            Show
            salnikov Andy Salnikov added a comment - Jonathan Sick , thanks for catching that, actually manifest was already OK, but I forgot to rename doc/lsst.dax.ppdb. Everything should be OK on a branch now, and I will need to merge all branches at the same time. https://github.com/lsst-dm/dax_apdb/blob/tickets/DM-22039/doc/manifest.yaml https://github.com/lsst-dm/dax_apdb/tree/tickets/DM-22039/doc
            Hide
            mrawls Meredith Rawls added a comment -

            For my piece (ap_pipe-notebooks), the changes were straightforward, thank you. As noted on GitHub, I would appreciate if you could also update two READMEs in that repo since some of the material falls somewhere in between "record of past work" and "examples for future use." Explicitly noting breaking changes like this in the README, as there is no docs directory, can only help future users.

            Show
            mrawls Meredith Rawls added a comment - For my piece (ap_pipe-notebooks), the changes were straightforward, thank you. As noted on GitHub, I would appreciate if you could also update two READMEs in that repo since some of the material falls somewhere in between "record of past work" and "examples for future use." Explicitly noting breaking changes like this in the README, as there is no docs directory, can only help future users.
            Hide
            jsick Jonathan Sick added a comment -

            Andy Salnikov, the pipelines_lsst_io and doc directory of dax_apdb look good. Thanks!

            Show
            jsick Jonathan Sick added a comment - Andy Salnikov , the pipelines_lsst_io and doc directory of dax_apdb look good. Thanks!
            jsick Jonathan Sick made changes -
            Reviewers Chris Morrison, Jonathan Sick, Meredith Rawls [ cmorrison, jsick, mrawls ] Chris Morrison, Meredith Rawls [ cmorrison, mrawls ]
            mrawls Meredith Rawls made changes -
            Reviewers Chris Morrison, Meredith Rawls [ cmorrison, mrawls ] Chris Morrison [ cmorrison ]
            Hide
            cmorrison Chris Morrison [X] (Inactive) added a comment -

            Hey, Andy Salnikov, finished my set of packages. You're clear to mark it reviewed from my end.

            Show
            cmorrison Chris Morrison [X] (Inactive) added a comment - Hey,  Andy Salnikov , finished my set of packages. You're clear to mark it reviewed from my end.
            Hide
            salnikov Andy Salnikov added a comment - - edited

            Thank you all reviewers! I'm updating ticket as reviewed. After rebasing Jenkins looks happy with my branch build (https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30802/pipeline) so I'm going to merge all PRs soon.

            Show
            salnikov Andy Salnikov added a comment - - edited Thank you all reviewers! I'm updating ticket as reviewed. After rebasing Jenkins looks happy with my branch build ( https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30802/pipeline ) so I'm going to merge all PRs soon.
            salnikov Andy Salnikov made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            salnikov Andy Salnikov made changes -
            Remote Link This issue links to "Page (Confluence)" [ 22472 ]
            Show
            salnikov Andy Salnikov added a comment - Announcement went here: https://community.lsst.org/t/completing-renaming-of-dax-ppdb-into-dax-apdb/3938
            salnikov Andy Salnikov made changes -
            Story Points 4 6
            Hide
            salnikov Andy Salnikov added a comment -

            All is merged, packages were moved between organizations. I started Jenkins build with master to see if anything breaks: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30808/pipeline

            Show
            salnikov Andy Salnikov added a comment - All is merged, packages were moved between organizations. I started Jenkins build with master to see if anything breaks: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30808/pipeline
            Hide
            salnikov Andy Salnikov added a comment -

            OK, Jenkins build of master was OK, so I declare success and close this ticket. Any problems that we find later should be followed up on new tickets.

            Show
            salnikov Andy Salnikov added a comment - OK, Jenkins build of master was OK, so I declare success and close this ticket. Any problems that we find later should be followed up on new tickets.
            salnikov Andy Salnikov made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            tjenness Tim Jenness made changes -
            Link This issue relates to DM-22511 [ DM-22511 ]
            npease Nate Pease [X] (Inactive) made changes -
            Epic Link DM-20079 [ 318927 ]
            salnikov Andy Salnikov made changes -
            Link This issue is triggering DM-20580 [ DM-20580 ]
            salnikov Andy Salnikov made changes -
            Link This issue is triggering DM-20580 [ DM-20580 ]
            salnikov Andy Salnikov made changes -
            Link This issue is triggering DM-23214 [ DM-23214 ]

              People

              Assignee:
              salnikov Andy Salnikov
              Reporter:
              salnikov Andy Salnikov
              Reviewers:
              Chris Morrison [X] (Inactive)
              Watchers:
              Andy Salnikov, Chris Morrison [X] (Inactive), Jonathan Sick, Krzysztof Findeisen, Meredith Rawls
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.