Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-22066

Fix issues discovered in SLAC rotator testing

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Epic Link:
    • Sprint:
      TSSW Sprint - Oct 28 - Nov 10, TSSW Sprint - Nov 11 - Nov 22
    • Team:
      Telescope and Site

      Description

      In SLAC rotator testing today we discovered several issues that need fixing:

      • The counter field was the wrong type for Command and Header (should be uint, not ushort).
      • The rotator and hexapod CSCs have no heartbeat output. This strongly suggests we should have a base class for both CSCs.
      • The rotator commander outputs too much noise because of encoder jitter (not a surprise). This is likely an issue for the hexapod commander as well.

      Note that we still were not able to command the rotator: the commands were ignored. Fixing that is a different ticket.

      I have attached a file that shows some binary telemetry data we read from the rotator, and how the Python code parses it.

        Attachments

          Issue Links

          mitigates

          Improvement - An improvement or enhancement to an existing feature or task. DM-22150 The Rotator and Hexapod CSCs should reject all commands when the device is not commandable

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-22067 Diagnose failure to command rotator

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-22146 Test the Rotator/ Hexapod CSC based on ts_salobj

          • Done

          Improvement - An improvement or enhancement to an existing feature or task. DM-22104 Refactor ts_rotator and ts_hexapod to put more common code in ts_hexrotcomm

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-21951 Support November 1 rotator tests at SLAC

          • Done

            Activity

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Te-Wei Tsai
              Watchers:
              Russell Owen, Te-Wei Tsai, Tiago Ribeiro
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.