Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-22068

Add ABC, StorageClass, and Formatter for stray-light correction

    XMLWordPrintable

    Details

      Description

      In order to support butler I/O for HSC's bespoke stray-light correction files, we should:

      • Add an abstract base class for camera-generic stray light correction information to ip_isr, and make the implementation in obs_subaru inherit from it.
      • Add a StorageClass to daf_butler for the abstract base class.
      • Add a formatter to obs_subaru for the concrete HSC class.
      • Add code and possibly a script to ingest the stray light data into a Gen3 repository.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-21739 Enable fringe and HSC y-band stray light correction in Gen3 IsrTask

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Christopher Waters, here's what I had in mind for putting the stray light data behind the butler.  You're welcome to rebase your DM-21739 branches on these and merge them with that ticket, or just finish that ticket first and let me integrate these changes with those after they land on master (I'm happy to do that integration work, though I may ask for you to test it as part of a second review pass).

            Anyhow, there are three packages with branches here, but they're not actually hooked up to ISR yet, so I haven't tested them but they should do no harm as-is:

             

            Show
            jbosch Jim Bosch added a comment - Christopher Waters , here's what I had in mind for putting the stray light data behind the butler.  You're welcome to rebase your DM-21739 branches on these and merge them with that ticket, or just finish that ticket first and let me integrate these changes with those after they land on master (I'm happy to do that integration work, though I may ask for you to test it as part of a second review pass). Anyhow, there are three packages with branches here, but they're not actually hooked up to ISR yet, so I haven't tested them but they should do no harm as-is: https://github.com/lsst/ip_isr/pull/114 https://github.com/lsst/daf_butler/pull/201 https://github.com/lsst/obs_subaru/pull/227  
            Hide
            Permalink
            czw Christopher Waters added a comment -

            This looks good to me. I plan on testing it with DM-21739's code, which I plan to send to review today. Either way it'll need a unification test, so I'll try to get a command line ready for that.

            Show
            czw Christopher Waters added a comment - This looks good to me. I plan on testing it with DM-21739 's code, which I plan to send to review today. Either way it'll need a unification test, so I'll try to get a command line ready for that.

              People

              Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Christopher Waters
              Watchers:
              Christopher Waters, Jim Bosch
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.