Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-22114

Remove deprecated `makeDistortedTanWcs`

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
    • Story Points:
      2
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      DM-20937 deprecated makeDistortedTanWcs as part of release v19. We can remove it as part of v20.

        Attachments

          Issue Links

            Activity

            Hide
            swinbank John Swinbank added a comment -

            The warning that was added on DM-20937 says this code is “to be removed after v20”, not before. Will update blockers on this ticket appropriately.

            Show
            swinbank John Swinbank added a comment - The warning that was added on DM-20937 says this code is “to be removed after v20”, not before. Will update blockers on this ticket appropriately.
            Hide
            kannawad Arun Kannawadi added a comment -

            Done as a pair-coding exercise with Clare Saunders

            Show
            kannawad Arun Kannawadi added a comment - Done as a pair-coding exercise with Clare Saunders
            Show
            kannawad Arun Kannawadi added a comment - The Jenkins build has passed successfully:  https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/32799/pipeline
            Hide
            yusra Yusra AlSayyad added a comment -

            John Parejko  Can get to this review sometime before Arun gets back next week? If not, I'll reassign.  This is a release blocker.

            Show
            yusra Yusra AlSayyad added a comment - John Parejko   Can get to this review sometime before Arun gets back next week? If not, I'll reassign.  This is a release blocker.
            Hide
            Parejkoj John Parejko added a comment -

            I made a comment on the PR, but need feedback on that before I can review.

            Show
            Parejkoj John Parejko added a comment - I made a comment on the PR, but need feedback on that before I can review.
            Hide
            kannawad Arun Kannawadi added a comment -

            Yup, the ball is in my court. I'll rebase it to make the git diff more readable and push it the first thing tomorrow.

            Show
            kannawad Arun Kannawadi added a comment - Yup, the ball is in my court. I'll rebase it to make the git diff more readable and push it the first thing tomorrow.
            Hide
            kannawad Arun Kannawadi added a comment - - edited

            Yet another Jenkins build after splitting the changes into two commits. This is mainly to ensure I didn't drop anything crucial when I kept resetting git head: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/32915/pipeline

            Show
            kannawad Arun Kannawadi added a comment - - edited Yet another Jenkins build after splitting the changes into two commits. This is mainly to ensure I didn't drop anything crucial when I kept resetting git head: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/32915/pipeline
            Hide
            Parejkoj John Parejko added a comment -

            Thanks for reworking that: looking at the individual commits now made a lot more sense.

            Show
            Parejkoj John Parejko added a comment - Thanks for reworking that: looking at the individual commits now made a lot more sense.

              People

              • Assignee:
                kannawad Arun Kannawadi
                Reporter:
                Parejkoj John Parejko
                Reviewers:
                John Parejko
                Watchers:
                Arun Kannawadi, John Parejko, John Swinbank, Yusra AlSayyad
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: