# Remove deprecated makeDistortedTanWcs

XMLWordPrintable

## Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
• Story Points:
2
• Team:
• Urgent?:
No

## Description

DM-20937 deprecated makeDistortedTanWcs as part of release v19. We can remove it as part of v20.

## Activity

Hide
John Swinbank added a comment -

The warning that was added on DM-20937 says this code is “to be removed after v20”, not before. Will update blockers on this ticket appropriately.

Show
John Swinbank added a comment - The warning that was added on DM-20937 says this code is “to be removed after v20”, not before. Will update blockers on this ticket appropriately.
Hide

Done as a pair-coding exercise with Clare Saunders

Show
Arun Kannawadi added a comment - Done as a pair-coding exercise with Clare Saunders
Hide
Show
Arun Kannawadi added a comment - The Jenkins build has passed successfully:  https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/32799/pipeline
Hide

John Parejko  Can get to this review sometime before Arun gets back next week? If not, I'll reassign.  This is a release blocker.

Show
Yusra AlSayyad added a comment - John Parejko   Can get to this review sometime before Arun gets back next week? If not, I'll reassign.  This is a release blocker.
Hide
John Parejko added a comment -

I made a comment on the PR, but need feedback on that before I can review.

Show
John Parejko added a comment - I made a comment on the PR, but need feedback on that before I can review.
Hide

Yup, the ball is in my court. I'll rebase it to make the git diff more readable and push it the first thing tomorrow.

Show
Arun Kannawadi added a comment - Yup, the ball is in my court. I'll rebase it to make the git diff more readable and push it the first thing tomorrow.
Hide
Arun Kannawadi added a comment - - edited

Yet another Jenkins build after splitting the changes into two commits. This is mainly to ensure I didn't drop anything crucial when I kept resetting git head: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/32915/pipeline

Show
Arun Kannawadi added a comment - - edited Yet another Jenkins build after splitting the changes into two commits. This is mainly to ensure I didn't drop anything crucial when I kept resetting git head: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/32915/pipeline
Hide
John Parejko added a comment -

Thanks for reworking that: looking at the individual commits now made a lot more sense.

Show
John Parejko added a comment - Thanks for reworking that: looking at the individual commits now made a lot more sense.

## People

• Assignee:
Reporter:
John Parejko
Reviewers:
John Parejko
Watchers:
Arun Kannawadi, John Parejko, John Swinbank, Yusra AlSayyad