Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-22148

Fix HSC ingestion: autoguider unset

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_subaru
    • Labels:
    • Team:
      External

      Description

      The T_AG header (from which we set the autoguider field in the registry) isn't always set, which leads to ingest breaking.

        Attachments

          Activity

          Hide
          price Paul Price added a comment -

          Christopher Waters, this is a small fix for an issue I discovered while ingesting lots of HSC data at Princeton. Would you mind signing off on it, please?

          Show
          price Paul Price added a comment - Christopher Waters , this is a small fix for an issue I discovered while ingesting lots of HSC data at Princeton. Would you mind signing off on it, please?
          Hide
          czw Christopher Waters added a comment -

          It makes sense to get this in now, so the HSC ingest can continue.

          I am curious (and slightly concerned) that this indicates a divergence between gen2/HSC and gen3, in that the autoguider seems ignored completely by lsst.obs.subaru.gen3.hsc.rawFormatter and astro_metadata_translator. It might be good to file a ticket about this, just to ensure someone thinks about this when gen3 becomes the standard.

          Show
          czw Christopher Waters added a comment - It makes sense to get this in now, so the HSC ingest can continue. I am curious (and slightly concerned) that this indicates a divergence between gen2/HSC and gen3, in that the autoguider seems ignored completely by lsst.obs.subaru.gen3.hsc.rawFormatter and astro_metadata_translator. It might be good to file a ticket about this, just to ensure someone thinks about this when gen3 becomes the standard.
          Hide
          price Paul Price added a comment -

          Thanks Chris. My uninformed understanding is that Gen3 has deliberately ignored instrument/observatory-specific fields that Gen2 made so easy to accommodate. Nate Lust or Jim Bosch may have an opinion, and I'll leave it up to them to file a ticket if they think it's important.

          Merged to master.

          Show
          price Paul Price added a comment - Thanks Chris. My uninformed understanding is that Gen3 has deliberately ignored instrument/observatory-specific fields that Gen2 made so easy to accommodate. Nate Lust or Jim Bosch may have an opinion, and I'll leave it up to them to file a ticket if they think it's important. Merged to master.
          Hide
          tjenness Tim Jenness added a comment -

          obs_subaru has things like CCD temp that are also not part of the Gen3 data model. There is an attempt to be generic in the gen3 data model so some thought would be needed to translate these concepts to general form. I think that Jim Bosch at one point considered a core Instrument model and instrument-specific extensions. The problem with the instrument specific extensions is that you then rediscover the problem we had with gen 2 which is the same concept ends up being called different things in different instruments.

          Show
          tjenness Tim Jenness added a comment - obs_subaru has things like CCD temp that are also not part of the Gen3 data model. There is an attempt to be generic in the gen3 data model so some thought would be needed to translate these concepts to general form. I think that Jim Bosch at one point considered a core Instrument model and instrument-specific extensions. The problem with the instrument specific extensions is that you then rediscover the problem we had with gen 2 which is the same concept ends up being called different things in different instruments.
          Hide
          jbosch Jim Bosch added a comment -

          Until we start getting into really obscure stuff, I would like to always add anything any instrument needs to the common fields, while thinking about generic terminology for them (e.g., HSC has a "pointing" field that it needs but which doesn't mean what most of us would think of if we called it "pointing", so we should store that data while thinking of a different name that might be usable for some other telescope).

          Show
          jbosch Jim Bosch added a comment - Until we start getting into really obscure stuff, I would like to always add anything any instrument needs to the common fields, while thinking about generic terminology for them (e.g., HSC has a "pointing" field that it needs but which doesn't mean what most of us would think of if we called it "pointing", so we should store that data while thinking of a different name that might be usable for some other telescope).

            People

            • Assignee:
              price Paul Price
              Reporter:
              price Paul Price
              Reviewers:
              Christopher Waters
              Watchers:
              Christopher Waters, Jim Bosch, Paul Price, Tim Jenness
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: