Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: lsst_ci, pipe_tasks, testdata_jointcal
-
Labels:None
-
Team:System Management
Description
astrometry_net_data is an optional dependency of pipe_tasks. The relevant methods from pipe_tasks (setConfigFromEups are currently used in lsst_ci and testdata_jointcal.
The testdata_jointcal usage is purely from a config file created from a dump which includes imports of every lsst package that was loaded when the config was written. This is trivial to fix. The lsst_ci usage includes code to set processCcd configurations that I believe are no longer relevant since we are not use astrometry_net any more.
Attachments
Issue Links
- blocks
-
- Done
- relates to
-
- Done
- mentioned in
-
Page Loading...
-
-
-
-
-
-
-
-
-
-
-
-
-
Activity
(mostly duplicating a comment on the PR)
Michael Wood-Vasey you added this config file to lsst_ci in DM-14272 – I'm wondering if it still needs to exist at all. It's clear that nothing in lsst_ci is using it because if it was it would be complaining about meas_extension_astrometryNet not existing. Can we delete it?
As long as you don't plan on adding HSC to the CI tests in lsst_ci, yes, you can remove this and the related script in scripts. More detailed comment on PR.
https://github.com/lsst/lsst_ci/pull/15#issuecomment-624088235
Michael Wood-Vasey
added a comment - As long as you don't plan on adding HSC to the CI tests in lsst_ci , yes, you can remove this and the related script in scripts . More detailed comment on PR.
https://github.com/lsst/lsst_ci/pull/15#issuecomment-624088235 I guess at some point we should be running HSC tests so would want to keep this around. Although no-one has run that tests script in a long time given that it would have failed immediately if they had.
Wil O'Mullane I suppose we keep the script and config around and remove all the cruft from the script that we know won't work.
I believe that is the current state so I will merge this and close the ticket.
testdata_jointcal will not be modified John Parejko says its a record of how the data was created. Presumably when we remove the refs from the other packages next time it will disappear from testdata_joiintcal..