Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-22234

Remove residual python_future usage from stack

    Details

    • Story Points:
      1.5
    • Sprint:
      Arch 2019-11-11, Arch 2019-11-18
    • Team:
      Architecture

      Description

      There are some packages in lsst_distrib that still use python future to support python 2.7. In some cases these are residual table file mentions or a handful of imports of past.builtins. Clean these up.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment - - edited

            Looking for:

            from past.builtins import...
            from future.utils import...
            from future import...
            from __future__ import...
            

            also from builtins import is probably a porting crutch and we do not want to inherit from object.

            Show
            tjenness Tim Jenness added a comment - - edited Looking for: from past.builtins import... from future.utils import... from future import... from __future__ import... also from builtins import is probably a porting crutch and we do not want to inherit from object .
            Hide
            tjenness Tim Jenness added a comment -

            Kian-Tat Lim I've gone through all the lsst_distrib packages plus db, cat, and qserv, and removed all the python future usage (which includes importing things from builtins for no reason). I've also removed inheriting of object.

            Some of these have been approved and merged by obvious candidates but a few still remain. Jenkins passed for lsst_distrib and Travis passes for qserv (I've asked Andy Salnikov to look at that one).

            After this lsst_distrib only uses Python future for galsim and coord third party packages.

            Show
            tjenness Tim Jenness added a comment - Kian-Tat Lim I've gone through all the lsst_distrib packages plus db, cat, and qserv, and removed all the python future usage (which includes importing things from builtins for no reason). I've also removed inheriting of object . Some of these have been approved and merged by obvious candidates but a few still remain. Jenkins passed for lsst_distrib and Travis passes for qserv (I've asked Andy Salnikov to look at that one). After this lsst_distrib only uses Python future for galsim and coord third party packages.
            Hide
            tjenness Tim Jenness added a comment -

            Chris Morrison would you mind looking at the two line change to ap_association?

            Steve Pietrowicz would you mind looking at ctrl_orca?

            Show
            tjenness Tim Jenness added a comment - Chris Morrison would you mind looking at the two line change to ap_association? Steve Pietrowicz would you mind looking at ctrl_orca?
            Hide
            spietrowicz Steve Pietrowicz added a comment -

            Tim Jenness I reviewed it, and the changes to ctrl_orca look fine.

            Show
            spietrowicz Steve Pietrowicz added a comment - Tim Jenness I reviewed it, and the changes to ctrl_orca look fine.
            Hide
            ktl Kian-Tat Lim added a comment -

            Good riddance

            Show
            ktl Kian-Tat Lim added a comment - Good riddance
            Hide
            tjenness Tim Jenness added a comment -

            All PRs merged except for the firefly_client one. I'm leaving that for David Shupe to deal with since it's a fork of the upstream IPAC version.

            Show
            tjenness Tim Jenness added a comment - All PRs merged except for the firefly_client one. I'm leaving that for David Shupe to deal with since it's a fork of the upstream IPAC version.

              People

              • Assignee:
                tjenness Tim Jenness
                Reporter:
                tjenness Tim Jenness
                Reviewers:
                Kian-Tat Lim
                Watchers:
                Kian-Tat Lim, Steve Pietrowicz, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel