Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-22256

Remove SkipUnless PyArrow when PyArrow works with macos stack

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Story Points:
      1
    • Sprint:
      DRP S20-5 (Apr)
    • Team:
      Data Release Production
    • Urgent?:
      No

      Description

      PyArrow is in our shared stack on lsst-dev and LSP. However, the version in the stack depends on a newer boost than our eups boost. In order to unblock DM-16234, we are skipping the unittests that require pyarrow, unless pyarrow can be imported. This way it still gets test coverage on the linux Jenkins nodes.

      Remove these skipUnless's when we can import pyarrow on a macos build stack.

        Attachments

          Issue Links

            Activity

            Hide
            hchiang2 Hsin-Fang Chiang added a comment -

            When doing this please also revert the workaround added in ci_hsc_gen2 in DM-22371 (this commit: https://github.com/lsst/ci_hsc_gen2/commit/a566e38bb5c857abc46bcb345add7237588db9a6 )

            Show
            hchiang2 Hsin-Fang Chiang added a comment - When doing this please also revert the workaround added in ci_hsc_gen2 in DM-22371 (this commit: https://github.com/lsst/ci_hsc_gen2/commit/a566e38bb5c857abc46bcb345add7237588db9a6 )
            Hide
            tjenness Tim Jenness added a comment -

            Was this fixed by upgrading the pyarrow version?

            Show
            tjenness Tim Jenness added a comment - Was this fixed by upgrading the pyarrow version?
            Hide
            yusra Yusra AlSayyad added a comment -

            ooooo, I'll give it a whirl on Jenkins now

            Show
            yusra Yusra AlSayyad added a comment - ooooo, I'll give it a whirl on Jenkins now
            Hide
            yusra Yusra AlSayyad added a comment -

            Jenkin's run looks good: 

            https://ci.lsst.codes/job/stack-os-matrix/31550/display/redirect

            and https://ci.lsst.codes/job/stack-os-matrix/31562/display/redirect running now incase the transient centos error wasn't transient. 

            Hsin-Fang Chiang will you review? There's a PR on ci_hsc_gen2 and pipe_tasks. 

            Show
            yusra Yusra AlSayyad added a comment - Jenkin's run looks good:  https://ci.lsst.codes/job/stack-os-matrix/31550/display/redirect and https://ci.lsst.codes/job/stack-os-matrix/31562/display/redirect  running now incase the transient centos error wasn't transient.  Hsin-Fang Chiang will you review? There's a PR on ci_hsc_gen2 and pipe_tasks. 
            Hide
            hchiang2 Hsin-Fang Chiang added a comment -

            Great this works now!

            See one comment on the PR.

            Show
            hchiang2 Hsin-Fang Chiang added a comment - Great this works now! See one comment on the PR.
            Hide
            hchiang2 Hsin-Fang Chiang added a comment -

            Ah and found one more file ci_hsc_gen2/python/lsst/ci/hsc/gen2/validate.py with the try block that can be removed

            Show
            hchiang2 Hsin-Fang Chiang added a comment - Ah and found one more file ci_hsc_gen2/python/lsst/ci/hsc/gen2/validate.py with the try block that can be removed
            Hide
            yusra Yusra AlSayyad added a comment -

            Thanks! I ended up putting it on two commits because I missed the validate.py one before merging the first time. :facepalm:

            Show
            yusra Yusra AlSayyad added a comment - Thanks! I ended up putting it on two commits because I missed the validate.py one before merging the first time. :facepalm:

              People

              • Assignee:
                yusra Yusra AlSayyad
                Reporter:
                yusra Yusra AlSayyad
                Reviewers:
                Hsin-Fang Chiang
                Watchers:
                Hsin-Fang Chiang, Tim Jenness, Yusra AlSayyad
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel