Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-22275

Filter telemetry in command_hexapod.py

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Epic Link:
    • Sprint:
      TSSW Sprint - Nov 11 - Nov 22
    • Team:
      Telescope and Site

      Description

      Ignore telemetry that change only slightly in command_hexapod.py. Add some jitter to the mock controller to exercise this change.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          rowen Russell Owen added a comment -

          ts_hexapod pull request: https://github.com/lsst-ts/ts_hexapod/pull/6

          Show
          rowen Russell Owen added a comment - ts_hexapod pull request: https://github.com/lsst-ts/ts_hexapod/pull/6
          Hide
          Permalink
          ttsai Te-Wei Tsai added a comment -

          The update looks good! Good job!

          Show
          ttsai Te-Wei Tsai added a comment - The update looks good! Good job!
          Hide
          Permalink
          rowen Russell Owen added a comment -

          Te-Wei's detailed review:

          [hexapod_commander.py]
          1. It might be good to add the data type of input arguments of functions:
          https://github.com/lsst-ts/ts_hexapod/pull/6/files#diff-fb390c2510ff1f2ef6fa6a4c8ace59ecR127
          https://github.com/lsst-ts/ts_hexapod/pull/6/files#diff-fb390c2510ff1f2ef6fa6a4c8ace59ecR139
          https://github.com/lsst-ts/ts_hexapod/pull/6/files#diff-fb390c2510ff1f2ef6fa6a4c8ace59ecR146
          2. It might be good to add the doc string of functions:
          https://github.com/lsst-ts/ts_hexapod/pull/6/files#diff-fb390c2510ff1f2ef6fa6a4c8ace59ecR139
          https://github.com/lsst-ts/ts_hexapod/pull/6/files#diff-fb390c2510ff1f2ef6fa6a4c8ace59ecR146

          Show
          rowen Russell Owen added a comment - Te-Wei's detailed review: [hexapod_commander.py] 1. It might be good to add the data type of input arguments of functions: https://github.com/lsst-ts/ts_hexapod/pull/6/files#diff-fb390c2510ff1f2ef6fa6a4c8ace59ecR127 https://github.com/lsst-ts/ts_hexapod/pull/6/files#diff-fb390c2510ff1f2ef6fa6a4c8ace59ecR139 https://github.com/lsst-ts/ts_hexapod/pull/6/files#diff-fb390c2510ff1f2ef6fa6a4c8ace59ecR146 2. It might be good to add the doc string of functions: https://github.com/lsst-ts/ts_hexapod/pull/6/files#diff-fb390c2510ff1f2ef6fa6a4c8ace59ecR139 https://github.com/lsst-ts/ts_hexapod/pull/6/files#diff-fb390c2510ff1f2ef6fa6a4c8ace59ecR146
          Hide
          Permalink
          rowen Russell Owen added a comment - - edited

          My response:

          Excellent suggestions. The documentation for HexapodCommander was quite weak. I added doc strings for the class and all methods, and documented the arguments. It is difficult to give a sensible data type for telemetry callbacks, but I did my best.

          Show
          rowen Russell Owen added a comment - - edited My response: Excellent suggestions. The documentation for HexapodCommander was quite weak. I added doc strings for the class and all methods, and documented the arguments. It is difficult to give a sensible data type for telemetry callbacks, but I did my best.
          Hide
          Permalink
          rowen Russell Owen added a comment -

          Merged to develop and master and tagged v0.2.0

          Show
          rowen Russell Owen added a comment - Merged to develop and master and tagged v0.2.0

            People

            Assignee:
            rowen Russell Owen
            Reporter:
            rowen Russell Owen
            Reviewers:
            Te-Wei Tsai
            Watchers:
            Russell Owen, Te-Wei Tsai
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.