Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-22277

Convert TransformObjectTableTask and friends to Gen 3

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Story Points:
      2
    • Epic Link:
    • Sprint:
      DRP F19-6 (Nov), DRP S20-2 (Jan), DRP S20-3 (Feb), DRP S20-5 (Apr), DRP S20-6 (May), DRP F20-1 (June), DRP F20-2 (July), DRP F20-3 (Aug), DRP F20-5 (Oct), DRP S21a (Dec Jan)
    • Team:
      Data Release Production
    • Urgent?:
      No

      Attachments

        Issue Links

        mentioned in

        Page Loading...

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          yusra Yusra AlSayyad added a comment - - edited

          Ready for review.
          These tasks are run in ci_hsc. Jenkins working here: https://ci.lsst.codes/job/stack-os-matrix/33916/display/redirect

          Will compare the Gen2 and Gen3 file contents from ci_hsc tomorrow. We don't necessarily expect these to work on older converted repos. Bands are different in the older repos (These tasks run on older converted repos, but contents are NaN because of the bands) and patch numbers are strings->ints.

          Gen3 objectTables will have one more column: 'skymap'.

          Show
          yusra Yusra AlSayyad added a comment - - edited Ready for review. These tasks are run in ci_hsc . Jenkins working here: https://ci.lsst.codes/job/stack-os-matrix/33916/display/redirect Will compare the Gen2 and Gen3 file contents from ci_hsc tomorrow. We don't necessarily expect these to work on older converted repos. Bands are different in the older repos (These tasks run on older converted repos, but contents are NaN because of the bands) and patch numbers are strings->ints. Gen3 objectTables will have one more column: 'skymap'.
          Hide
          Permalink
          yusra Yusra AlSayyad added a comment -

          OK, made the 2 fixes you requested and checked the outputs.

          I'm glad I decided to try to get this ticket in before w14, because we haven't had colors in our object tables since the filter to band migration (in either Gen2 or Gen3). I opened a new PR for obs_subaru specifying the filters as 'r' rather than 'HSC-R'. This works in both Gen2 and Gen3. Also fixed the NaN reference columns ci_hsc where we only have 'r' and 'i'.

          New Jenkins working here: https://ci.lsst.codes/job/stack-os-matrix/33933/display/redirect

          Show
          yusra Yusra AlSayyad added a comment - OK, made the 2 fixes you requested and checked the outputs. I'm glad I decided to try to get this ticket in before w14, because we haven't had colors in our object tables since the filter to band migration (in either Gen2 or Gen3). I opened a new PR for obs_subaru specifying the filters as 'r' rather than 'HSC-R'. This works in both Gen2 and Gen3. Also fixed the NaN reference columns ci_hsc where we only have 'r' and 'i'. New Jenkins working here: https://ci.lsst.codes/job/stack-os-matrix/33933/display/redirect

            People

            Assignee:
            yusra Yusra AlSayyad
            Reporter:
            yusra Yusra AlSayyad
            Reviewers:
            Eli Rykoff
            Watchers:
            Eli Rykoff, Hsin-Fang Chiang, Yusra AlSayyad
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.