Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-22285

Update ups table in pipe_analysis to no longer require meas_mosaic

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_analysis
    • Labels:
      None
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      DRP F19-6 (Nov)
    • Team:
      Data Release Production

      Description

      meas_mosaic is not required to be setup for the pipe_analysis scripts. At present, one can still explicitly ask for meas_mosaic calibrations to be applied with the config useMeasMosaic=True (default is False), but should give you a helpful error message if you do ask for it and it’s not setup (i.e. import is in a try:).  The ups table needs to be updated to reflect this.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          lauren Lauren MacArthur added a comment -

          Could you give this a look when you have a moment?

          Show
          lauren Lauren MacArthur added a comment - Could you give this a look when you have a moment?
          Hide
          Permalink
          lauren Lauren MacArthur added a comment - - edited

          Grrr...I have now twice lost this comment I meant for you to see before I put it in for review:

          This branch sets up and visitAnalysis.py runs fine pointing at the RC/w_2019_34/DM-21091 rerun. If I add the config -c useMeasMosaic=True OR if I point to the PDR1 processing run of DM-10404 (which is old enough to only have meas_mosaic calibrations!), I get the following error message:

          ValueError: Cannot apply uber calibrations because meas_mosaic could not be imported.
          		 
          Either setup meas_mosaic or run with --config doApplyUberCal=False

          I also took the opportunity to add geom and astropy to the setupRequired list and I updated the afw.cameraGeom DetectorType enum to reflect recent changes on DM-18610 (on this commit).

          Show
          lauren Lauren MacArthur added a comment - - edited Grrr...I have now twice lost this comment I meant for you to see before I put it in for review: This branch sets up and visitAnalysis.py runs fine pointing at the RC/w_2019_34/ DM-21091 rerun. If I add the config -c useMeasMosaic=True OR if I point to the PDR1 processing run of DM-10404 (which is old enough to only have meas_mosaic calibrations!), I get the following error message: ValueError: Cannot apply uber calibrations because meas_mosaic could not be imported. Either setup meas_mosaic or run with --config doApplyUberCal=False I also took the opportunity to add geom and astropy to the setupRequired list and I updated the afw.cameraGeom DetectorType enum to reflect recent changes on DM-18610 (on this commit ).
          Hide
          Permalink
          hchiang2 Hsin-Fang Chiang added a comment -

          Thanks for fixing it! 

          Show
          hchiang2 Hsin-Fang Chiang added a comment - Thanks for fixing it! 

            People

            Assignee:
            lauren Lauren MacArthur
            Reporter:
            lauren Lauren MacArthur
            Reviewers:
            Hsin-Fang Chiang
            Watchers:
            Hsin-Fang Chiang, Lauren MacArthur, Yusra AlSayyad
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.