Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-22385

Some tests are failing in ts_hexapod v0.2.0

    XMLWordPrintable

    Details

    • Story Points:
      0
    • Epic Link:
    • Sprint:
      TSSW Sprint - Nov 25 - Dec 6
    • Team:
      Telescope and Site

      Description

      4 unit tests are failing in ts_hexapod v0.2.0. The cause is that I added jitter to the measured positions and didn't relax the comparison tolerances in the tests to accommodate.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          rowen Russell Owen added a comment -

          Pull request: https://github.com/lsst-ts/ts_hexapod/pull/7

          Show
          rowen Russell Owen added a comment - Pull request: https://github.com/lsst-ts/ts_hexapod/pull/7
          Hide
          Permalink
          ttsai Te-Wei Tsai added a comment -

          All test cases pass. Good job!

          Show
          ttsai Te-Wei Tsai added a comment - All test cases pass. Good job!
          Hide
          Permalink
          rowen Russell Owen added a comment -

          I also fixed the commander verbosity, because the existing rounding wasn't enough, and changed the mock controller to only add jitter when the mock controller is enabled.

          Merged to develop and master and tagged as v0.2.1

          Show
          rowen Russell Owen added a comment - I also fixed the commander verbosity, because the existing rounding wasn't enough, and changed the mock controller to only add jitter when the mock controller is enabled. Merged to develop and master and tagged as v0.2.1

            People

            Assignee:
            rowen Russell Owen
            Reporter:
            rowen Russell Owen
            Reviewers:
            Te-Wei Tsai
            Watchers:
            Russell Owen, Te-Wei Tsai
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.