Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-22405

Rewrite MeasurePhotonTransferCurveTask data types

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Currently, the objects .put() by the task are extremely hard to follow, let alone use. Dictionaries are nested very deep, with the final level being tuples (i.e. unnamed), which also don't agree with the docstrings, meaning reading the code is the only way to work out what object is actually for what.

      I'm not 100% sure whether this is a place to use dataclasses, or just a normal class to hold some of this info, but I think it's got to be one of the two really.

        Attachments

          Issue Links

            Activity

            Hide
            plazas Andrés Alejandro Plazas Malagón added a comment -

            The changes look good, and Merlin has shown that the code works. Small future tweaks will go in another ticket: DM-22512

            Show
            plazas Andrés Alejandro Plazas Malagón added a comment - The changes look good, and Merlin has shown that the code works. Small future tweaks will go in another ticket:  DM-22512

              People

              • Assignee:
                mfisherlevine Merlin Fisher-Levine
                Reporter:
                mfisherlevine Merlin Fisher-Levine
                Reviewers:
                Andrés Alejandro Plazas Malagón
                Watchers:
                Andrés Alejandro Plazas Malagón, John Swinbank, Merlin Fisher-Levine
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel