# SQuaSH being spammed with timestamps

XMLWordPrintable

## Details

• Type: Bug
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
None
• Story Points:
2
• Sprint:
AP S20-1 (December)
• Team:

## Description

DM-22093 added a "Task finished" timestamp to the metadata for all verify timing metrics. This inadvertantly caused the timestamps to be treated as tags in SQuaSH (see attached image), and will eventually bog down the server.

Change the timestamps from metadata to extras, which are not uploaded to SQuaSH. This is a breaking change, and will make accessing the data a bit clunkier:

 measurement.notes["end"] measurement.extras["end"].quantity # yes, still a str 

## Attachments

1. end_times.png
44 kB

## Activity

Hide
Krzysztof Findeisen added a comment -

Hi Chris Morrison, can you review this fix? I think it will break some of your test code, sorry about that.

Show
Krzysztof Findeisen added a comment - Hi Chris Morrison , can you review this fix? I think it will break some of your test code, sorry about that.
Hide
Chris Morrison added a comment -

Approved the pull request. I haven't exclusively started to use this output yet so no test code on my end will be broken yet.

Show
Chris Morrison added a comment - Approved the pull request. I haven't exclusively started to use this output yet so no test code on my end will be broken yet.
Hide
Krzysztof Findeisen added a comment -

I've fixed the code so that it won't upload more timestamps. Angelo Fausti, would it be worthwhile/possible to erase the existing *Time.end metadata from the SQuaSH DB? Unfortunately it's attached to about a dozen metrics.

Show
Krzysztof Findeisen added a comment - I've fixed the code so that it won't upload more timestamps. Angelo Fausti , would it be worthwhile/possible to erase the existing *Time.end metadata from the SQuaSH DB? Unfortunately it's attached to about a dozen metrics.
Hide
Angelo Fausti added a comment - - edited

Yes, I think that's possible. I'll have to rewrite the measurement without that tag following a procedure similar to the one described here Workaround for dropping individual field keys

Show
Angelo Fausti added a comment - - edited Yes, I think that's possible. I'll have to rewrite the measurement without that tag following a procedure similar to the one described here Workaround for dropping individual field keys

## People

• Assignee:
Krzysztof Findeisen
Reporter:
Krzysztof Findeisen
Reviewers:
Chris Morrison
Watchers:
Angelo Fausti, Chris Morrison, Krzysztof Findeisen