Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-22479

SQuaSH being spammed with timestamps

    XMLWordPrintable

Details

    • Bug
    • Status: Done
    • Resolution: Done
    • None
    • verify
    • None
    • 2
    • AP S20-1 (December)
    • Alert Production

    Description

      DM-22093 added a "Task finished" timestamp to the metadata for all verify timing metrics. This inadvertantly caused the timestamps to be treated as tags in SQuaSH (see attached image), and will eventually bog down the server.

      Change the timestamps from metadata to extras, which are not uploaded to SQuaSH. This is a breaking change, and will make accessing the data a bit clunkier:

      measurement.notes["end"]
      measurement.extras["end"].quantity  # yes, still a `str`
      

      Attachments

        Issue Links

          Activity

            Hi cmorrison, can you review this fix? I think it will break some of your test code, sorry about that.

            krzys Krzysztof Findeisen added a comment - Hi cmorrison , can you review this fix? I think it will break some of your test code, sorry about that.

            Approved the pull request. I haven't exclusively started to use this output yet so no test code on my end will be broken yet.

            cmorrison Chris Morrison [X] (Inactive) added a comment - Approved the pull request. I haven't exclusively started to use this output yet so no test code on my end will be broken yet.

            I've fixed the code so that it won't upload more timestamps. afausti, would it be worthwhile/possible to erase the existing *Time.end metadata from the SQuaSH DB? Unfortunately it's attached to about a dozen metrics.

            krzys Krzysztof Findeisen added a comment - I've fixed the code so that it won't upload more timestamps. afausti , would it be worthwhile/possible to erase the existing *Time.end metadata from the SQuaSH DB? Unfortunately it's attached to about a dozen metrics.
            afausti Angelo Fausti added a comment - - edited

            Yes, I think that's possible. I'll have to rewrite the measurement without that tag following a procedure similar to the one described here Workaround for dropping individual field keys

            afausti Angelo Fausti added a comment - - edited Yes, I think that's possible. I'll have to rewrite the measurement without that tag following a procedure similar to the one described here Workaround for dropping individual field keys

            People

              krzys Krzysztof Findeisen
              krzys Krzysztof Findeisen
              Chris Morrison [X] (Inactive)
              Angelo Fausti, Chris Morrison [X] (Inactive), Krzysztof Findeisen
              Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.