Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: verify
-
Labels:None
-
Story Points:2
-
Epic Link:
-
Sprint:AP S20-1 (December)
-
Team:Alert Production
Description
DM-22093 added a "Task finished" timestamp to the metadata for all verify timing metrics. This inadvertantly caused the timestamps to be treated as tags in SQuaSH (see attached image), and will eventually bog down the server.
Change the timestamps from metadata to extras, which are not uploaded to SQuaSH. This is a breaking change, and will make accessing the data a bit clunkier:
measurement.notes["end"] |
measurement.extras["end"].quantity # yes, still a `str` |
Attachments
Issue Links
- relates to
-
DM-22093 Store begin/end times of ap_pipe in ap_verify
- Done
Activity
Approved the pull request. I haven't exclusively started to use this output yet so no test code on my end will be broken yet.
I've fixed the code so that it won't upload more timestamps. Angelo Fausti, would it be worthwhile/possible to erase the existing *Time.end metadata from the SQuaSH DB? Unfortunately it's attached to about a dozen metrics. 
Krzysztof Findeisen
added a comment - I've fixed the code so that it won't upload more timestamps. Angelo Fausti , would it be worthwhile/possible to erase the existing *Time.end metadata from the SQuaSH DB? Unfortunately it's attached to about a dozen metrics. Yes, I think that's possible. I'll have to rewrite the measurement without that tag following a procedure similar to the one described here Workaround for dropping individual field keys
Hi Chris Morrison [X], can you review this fix? I think it will break some of your test code, sorry about that.