Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-22540

Include only real acronyms in acronyms.tex

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Team:
      Architecture

      Description

      The script generateAcronyms.py should be updated in order to include only acronyms in the acronyms table, when executed with the -t option (generate acronyms table)

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            I thought master looks for upper case characters that match the regex and ALSO forms a special regex based on the supplied acronyms that are not just made of upper case characters.

            Show
            tjenness Tim Jenness added a comment - I thought master looks for upper case characters that match the regex and ALSO forms a special regex based on the supplied acronyms that are not just made of upper case characters.
            Hide
            gcomoretto Gabriele Comoretto (Inactive) added a comment -

            https://github.com/lsst/lsst-texmf/blob/master/bin/generateAcronyms.py#L42

             

            CAP_ACRONYM = re.compile(r"\b[A-Z][A-Z]+\b")

             

            Just 2 or more upper case characters.

            Show
            gcomoretto Gabriele Comoretto (Inactive) added a comment - https://github.com/lsst/lsst-texmf/blob/master/bin/generateAcronyms.py#L42   CAP_ACRONYM = re.compile(r"\b [A-Z] [A-Z] +\b")   Just 2 or more upper case characters.
            Show
            tjenness Tim Jenness added a comment - Yes, but I'm talking about https://github.com/lsst/lsst-texmf/blob/master/bin/generateAcronyms.py#L344
            Hide
            gcomoretto Gabriele Comoretto (Inactive) added a comment -

            That's the list of defined entries in glossarydefs.csv+myacronyms-skipacronyms.It is used to find all the matches between the glossary definitions and what is used.

            The regular expression I am referring to, is used on line 352 to find all potential acronyms-like strings (as per line 349) in the text. And it is looking on only full uppercase strings.

            From the difference with the matches, the missing ones are found.

            Show
            gcomoretto Gabriele Comoretto (Inactive) added a comment - That's the list of defined entries in glossarydefs.csv+myacronyms-skipacronyms.It is used to find all the matches between the glossary definitions and what is used. The regular expression I am referring to, is used on line 352 to find all potential acronyms-like strings  (as per line 349) in the text. And it is looking on only full uppercase strings. From the difference with the matches, the missing ones are found.
            Hide
            womullan Wil O'Mullane added a comment -

            I have checked this for both glossary and acronyms and it looks good. One small comment on github was fixed. There is still one comment from Tim on the regexp.. it could perhaps be simplified but I would not delay much on merging this. It is an improvement and it is good to flag acronyms separately to glossary entries. 

            Show
            womullan Wil O'Mullane added a comment - I have checked this for both glossary and acronyms and it looks good. One small comment on github was fixed. There is still one comment from Tim on the regexp.. it could perhaps be simplified but I would not delay much on merging this. It is an improvement and it is good to flag acronyms separately to glossary entries. 

              People

              Assignee:
              gcomoretto Gabriele Comoretto (Inactive)
              Reporter:
              gcomoretto Gabriele Comoretto (Inactive)
              Reviewers:
              Wil O'Mullane
              Watchers:
              Gabriele Comoretto (Inactive), John Swinbank, Kian-Tat Lim, Tim Jenness, Wil O'Mullane
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: