Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-22550

Handle latiss diffuser filter in obs_lsst

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • obs_lsst
    • None
    • 4
    • Arch 2019-12-02, Arch 2019-12-09
    • Architecture

    Description

      In DM-22366 it was reported that there is a filter in LATISS called "disperser" but it's actually meant to be called "diffuser". This ticket is therefore to:

      • Add metadata correction files to map disperser to diffuser
      • Add filter to the obs_lsst filter definitions
      • Add explicit LATISS filter list distinct from lsstCam in obs_lsst

      Attachments

        Issue Links

          Activity

            tjenness Tim Jenness added a comment -

            pingraham, tribeiro can you please take a look at the changes to the metadata translation and the filters for LATISS?

            The changes to tests and all the correction files come directly out of the changes to latiss.py and filters.py so please focus on those.

            tjenness Tim Jenness added a comment - pingraham , tribeiro can you please take a look at the changes to the metadata translation and the filters for LATISS? The changes to tests and all the correction files come directly out of the changes to latiss.py and filters.py so please focus on those.
            tjenness Tim Jenness added a comment -

            Parejkoj would you mind looking at the obs_base change to reset the filters?

            tjenness Tim Jenness added a comment - Parejkoj would you mind looking at the obs_base change to reset the filters?

            tjenness - Please set DARKTIME = EXPTIME whenever DARKTIME < EXPTIME and log that a correction was made

            Also, please set SHUTTIME = UNDEF as there is no capability to measure a shutter profile using a bonn shutter. Again, please log the correction.

            pingraham Patrick Ingraham (Inactive) added a comment - tjenness - Please set DARKTIME = EXPTIME whenever DARKTIME < EXPTIME and log that a correction was made Also, please set SHUTTIME = UNDEF as there is no capability to measure a shutter profile using a bonn shutter. Again, please log the correction.
            tjenness Tim Jenness added a comment -

            pingraham I've made the suggested change with one caveat. For the dark time fix I've applied that to the translator method rather than doing it in the header fix up method. I have some reasons for this:

            #. fix_header is called for every single header and sometimes multiple times even if DARKTIME is not being requested. I need to try to make fix_header as efficient as possible.
            #. Issuing a warning message every time fix_header is called will swamp the caller. I've added debug log messages for every fix up but mostly don't expect people to turn them on.
            #. Header fix ups should be fixing things where we know the right answer. In this case we don't know the right answer so I think it's better to defer the decision on how to calculate dark time until someone requests a dark time.

            tjenness Tim Jenness added a comment - pingraham I've made the suggested change with one caveat. For the dark time fix I've applied that to the translator method rather than doing it in the header fix up method. I have some reasons for this: #. fix_header is called for every single header and sometimes multiple times even if DARKTIME is not being requested. I need to try to make fix_header as efficient as possible. #. Issuing a warning message every time fix_header is called will swamp the caller. I've added debug log messages for every fix up but mostly don't expect people to turn them on. #. Header fix ups should be fixing things where we know the right answer. In this case we don't know the right answer so I think it's better to defer the decision on how to calculate dark time until someone requests a dark time.

            Review complete. 
            Note that discussion points may not be on this ticket but are contained in the PR.

            pingraham Patrick Ingraham (Inactive) added a comment - Review complete.  Note that discussion points may not be on this ticket but are contained in the PR.
            tjenness Tim Jenness added a comment -

            Thanks. Merged. mgower this should fix your diffuser/disperser problem and in theory you can remove your hack that lies about the filter in the registry.

            tjenness Tim Jenness added a comment - Thanks. Merged. mgower this should fix your diffuser/disperser problem and in theory you can remove your hack that lies about the filter in the registry.

            People

              tjenness Tim Jenness
              tjenness Tim Jenness
              Patrick Ingraham (Inactive), Tiago Ribeiro
              Merlin Fisher-Levine, Michelle Gower, Patrick Ingraham (Inactive), Tiago Ribeiro, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.