Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-22728

Handle immutable amplifiers in ip_isr test suite

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      The test case merged on DM-13440 assumed that it could modify amplifiers in-place to update their associated gain and read noise. However, this hasn't been possible since DM-18610 landed. Unfortunately, we didn't realise that before DM-13440 was merged, and now master is broken. Please fix it.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          swinbank John Swinbank added a comment -

          Hey Merlin, could you take a quick look please?

          PR: https://github.com/lsst/ip_isr/pull/121
          Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30931/pipeline

          Show
          swinbank John Swinbank added a comment - Hey Merlin, could you take a quick look please? PR: https://github.com/lsst/ip_isr/pull/121 Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30931/pipeline
          Hide
          Permalink
          mfisherlevine Merlin Fisher-Levine added a comment -

          I've checked it out and built locally and confirmed it passes, so suggest merging before Jenkins finishes, given that master is already broken.

          Show
          mfisherlevine Merlin Fisher-Levine added a comment - I've checked it out and built locally and confirmed it passes, so suggest merging before Jenkins finishes, given that master is already broken.
          Hide
          Permalink
          mfisherlevine Merlin Fisher-Levine added a comment -

          Merge ASAP.

          Show
          mfisherlevine Merlin Fisher-Levine added a comment - Merge ASAP.
          Hide
          Permalink
          swinbank John Swinbank added a comment -

          Done. Thanks for the quick turnaorund.

          Show
          swinbank John Swinbank added a comment - Done. Thanks for the quick turnaorund.

            People

            Assignee:
            swinbank John Swinbank
            Reporter:
            swinbank John Swinbank
            Reviewers:
            Merlin Fisher-Levine
            Watchers:
            John Swinbank, Leanne Guy, Merlin Fisher-Levine
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.