Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-22770

Remove duplication of BaseMapper

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_base, pipe_tasks
    • Labels:
      None
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      AP S20-1 (December)
    • Team:
      Alert Production

      Description

      pipe_tasks' tests/test_read_CuratedCalibs.py contains a copy of BaseMapper from obs_base's tests/test_cameraMapper.py. Not only is that ugly, it's also fragile (see DM-22769).

      Rearrange things so that pipe_tasks can import BaseMapper from obs_base directly.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-22769 Please do not strip {{tests/}} from Pipelines Docker images

          • To Do

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            swinbank John Swinbank added a comment - - edited

            Hey Simon Krughoff, do you have a moment to review this:

            PRs at:

            Jenkins:

            Note that the PR on obs_page is huge because I took the opportunity of updating the licensing boilerplate in all the files. Unless you really care about the boilerplate, you can probably get away with just looking at this commit.

            Show
            swinbank John Swinbank added a comment - - edited Hey Simon Krughoff , do you have a moment to review this: PRs at: https://github.com/lsst/obs_base/pull/193 https://github.com/lsst/pipe_tasks/pull/331 Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30941/pipeline (still in progress at time of writing) Note that the PR on obs_page is huge because I took the opportunity of updating the licensing boilerplate in all the files. Unless you really care about the boilerplate, you can probably get away with just looking at this commit .
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Jenkins #30941 failed with what appears to be a transient failure in obs_subaru. #30942 is already past that point.

            Show
            swinbank John Swinbank added a comment - Jenkins #30941 failed with what appears to be a transient failure in obs_subaru. #30942 is already past that point.
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            Looks like CI passed. The changes look good to me.

            Show
            krughoff Simon Krughoff added a comment - Looks like CI passed. The changes look good to me.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Thanks Simon Krughoff — now merged.

            Show
            swinbank John Swinbank added a comment - Thanks Simon Krughoff — now merged.

              People

              Assignee:
              swinbank John Swinbank
              Reporter:
              swinbank John Swinbank
              Reviewers:
              Simon Krughoff
              Watchers:
              John Swinbank, Simon Krughoff
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.