Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-22794

obs_base tests should not use daf_butler test configs

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_base
    • Labels:
      None
    • Story Points:
      1
    • Team:
      Architecture
    • Urgent?:
      No

      Description

      John Swinbank has noted that obs_base tests depend on a private butler config test file in DAF_BUTLER_DIR/tests/config. Those configs are not meant to be used outside of daf_butler since they contain unexpected formatters and storage classes designed specifically for internal daf_butler tests. obs_base should not be relying on those configurations. It should be sufficient for obs_base to use a default configuration made by Butler.makeRepo.

      I'm not entirely sure whether I should fix this or whether this should be handled by science pipelines.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-20994 Write how to make gen3 obs package guide

          • Done

          Improvement - An improvement or enhancement to an existing feature or task. DM-21016 Handle DECam instrument signature data in gen3

          • Done

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            tjenness Tim Jenness created issue -
            Parejkoj John Parejko made changes -
            Field Original Value New Value
            Link This issue relates to DM-20994 [ DM-20994 ]
            Parejkoj John Parejko made changes -
            Link This issue relates to DM-21016 [ DM-21016 ]
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Lets wait on this until DM-20994 and DM-21016 are further along/completed. I'd started to rework some things related to this dependency as part of that work.

            Show
            Parejkoj John Parejko added a comment - Lets wait on this until DM-20994 and DM-21016 are further along/completed. I'd started to rework some things related to this dependency as part of that work.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            We should discuss what the timeline for that is.

            The proximate issue is that this makes the Pipelines Docker images clunky/annoying/less useful for development. That's not a crisis, but it'd be nice to see it resolved in the next few weeks. If we can bring DM-20994 and DM-21016 to a conclusion in that timeframe, it'd be great.

            Show
            swinbank John Swinbank added a comment - We should discuss what the timeline for that is. The proximate issue is that this makes the Pipelines Docker images clunky/annoying/less useful for development. That's not a crisis , but it'd be nice to see it resolved in the next few weeks. If we can bring DM-20994 and DM-21016 to a conclusion in that timeframe, it'd be great.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            I'm not entirely sure whether I should fix this or whether this should be handled by science pipelines.

            I'd suggest that whoever has time first “should” fix it, but given John Parejko's comments above let's assume he'll take a look once the issues he refers to are moving.

            Show
            swinbank John Swinbank added a comment - I'm not entirely sure whether I should fix this or whether this should be handled by science pipelines. I'd suggest that whoever has time first “should” fix it, but given John Parejko 's comments above let's assume he'll take a look once the issues he refers to are moving.
            swinbank John Swinbank made changes -
            Assignee John Parejko [ parejkoj ]
            swinbank John Swinbank made changes -
            Team Alert Production [ 10300 ]
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            I will take this on. It looks like it's only a couple of lines to fix it and I have obs_base open in my editor.

            Show
            tjenness Tim Jenness added a comment - I will take this on. It looks like it's only a couple of lines to fix it and I have obs_base open in my editor.
            tjenness Tim Jenness made changes -
            Assignee John Parejko [ parejkoj ] Tim Jenness [ tjenness ]
            tjenness Tim Jenness made changes -
            Team Alert Production [ 10300 ] Architecture [ 10304 ]
            tjenness Tim Jenness made changes -
            Story Points 1
            Urgent? off
            tjenness Tim Jenness made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            tjenness Tim Jenness made changes -
            Reviewers John Parejko [ parejkoj ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thank you for dealing with this: looks like a simple fix.

            Show
            Parejkoj John Parejko added a comment - Thank you for dealing with this: looks like a simple fix.
            Parejkoj John Parejko made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            tjenness Tim Jenness made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              John Parejko
              Watchers:
              John Parejko, John Swinbank, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.