Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: None
-
Labels:None
-
Story Points:6
-
Epic Link:
-
Sprint:DRP F19-6 (Nov), DRP S20-2 (Jan)
-
Team:Data Release Production
Description
Some of the columns needed by pipe_analysis to identify if a source was used in calibration were not being propagated by processCcdWithFakes. This should be rectified by matching to the ic source catalog and including the required columns as is done in calibrate.py.
Attachments
Activity
Please add more details to the commit messages, and move unrelated changes to their own commit.
Is it possible to factor out code shared with CalibrateTask, or make this re-usable?
Otherwise, I put a bunch of minor issues on the GitHub PR.
Paul Price
added a comment - Please add more details to the commit messages, and move unrelated changes to their own commit.
Is it possible to factor out code shared with CalibrateTask , or make this re-usable?
Otherwise, I put a bunch of minor issues on the GitHub PR. I have moved the typo corrections to their own commit and added more details to the main commit message.
The code could possibly be moved into its own location so that it could be reused by other users. If people think that is useful I could file a ticket for that.
PR not showing up: https://github.com/lsst/pipe_tasks/pull/334
Jekins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30980/pipeline