Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-23026

Make sure calibration columns are propagating properly in processCcdWithFakes

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • None
    • None
    • 6
    • DRP F19-6 (Nov), DRP S20-2 (Jan)
    • Data Release Production

    Description

      Some of the columns needed by pipe_analysis to identify if a source was used in calibration were not being propagated by processCcdWithFakes. This should be rectified by matching to the ic source catalog and including the required columns as is done in calibrate.py.

      Attachments

        Activity

          sophiereed Sophie Reed added a comment - PR not showing up:  https://github.com/lsst/pipe_tasks/pull/334 Jekins:  https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30980/pipeline
          price Paul Price added a comment -

          Please add more details to the commit messages, and move unrelated changes to their own commit.

          Is it possible to factor out code shared with CalibrateTask, or make this re-usable?

          Otherwise, I put a bunch of minor issues on the GitHub PR.

          price Paul Price added a comment - Please add more details to the commit messages, and move unrelated changes to their own commit. Is it possible to factor out code shared with CalibrateTask , or make this re-usable? Otherwise, I put a bunch of minor issues on the GitHub PR.
          sophiereed Sophie Reed added a comment -

          I have moved the typo corrections to their own commit and added more details to the main commit message. 

          The code could possibly be moved into its own location so that it could be reused by other users. If people think that is useful I could file a ticket for that.

          sophiereed Sophie Reed added a comment - I have moved the typo corrections to their own commit and added more details to the main commit message.  The code could possibly be moved into its own location so that it could be reused by other users. If people think that is useful I could file a ticket for that.

          People

            sophiereed Sophie Reed
            sophiereed Sophie Reed
            Paul Price
            Jim Bosch, Paul Price, Sophie Reed, Yusra AlSayyad
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Jenkins

                No builds found.