Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-23034

Update cbp for changes in how Cameras and Detectors are built

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: cbp
    • Labels:
      None

      Description

      Please update the cbp package for change in how Detectors and Cameras are built.

      I suggest you use the tickets/DM-20488 branch or base your branch off of that one. Or, if you prefer, cherry-pick those changes.

      I think the main class that needs updating is SampleCoordinateConverter in testUtils.py.
      I had a try at this myself (see attached file), and was able to make a list of Detectors and get rid of the no-longer-needed AmpInfoTable (the test code doesn't care about amplifiers), but could not figure out how to create a Camera (nor verify that the Detectors I made were correct).

        Attachments

          Issue Links

            Activity

            rowen Russell Owen created issue -
            rowen Russell Owen made changes -
            Field Original Value New Value
            Link This issue relates to DM-20488 [ DM-20488 ]
            rowen Russell Owen made changes -
            Description Please update the cbp package for change in how Detectors and Cameras are built.

            I suggest you use the tickets/DM-20488 branch or base your branch off of that one. Or, if you prefer, cherry-pick those changes.
            Please update the cbp package for change in how Detectors and Cameras are built.

            I suggest you use the tickets/DM-20488 branch or base your branch off of that one. Or, if you prefer, cherry-pick those changes.

            I think the main class that needs updating is SampleCoordinateConverter in testUtils.py.
            I had a try at this myself, and was able to a list of Detectors, but could not figure out how to create a Camera.
            SampleCoordinateConverter._makeAmpInfoCatalog can almost certainly be deleted, since the cbp code does not care about amplifiers (I only created an AmpInfoTable because it was required to make a Detector, and that is no longer the case.

            I have attached my attempted update of testUtils.py in case it is a useful starting point.
            rowen Russell Owen made changes -
            Attachment testUtils.py [ 41940 ]
            rowen Russell Owen made changes -
            Description Please update the cbp package for change in how Detectors and Cameras are built.

            I suggest you use the tickets/DM-20488 branch or base your branch off of that one. Or, if you prefer, cherry-pick those changes.

            I think the main class that needs updating is SampleCoordinateConverter in testUtils.py.
            I had a try at this myself, and was able to a list of Detectors, but could not figure out how to create a Camera.
            SampleCoordinateConverter._makeAmpInfoCatalog can almost certainly be deleted, since the cbp code does not care about amplifiers (I only created an AmpInfoTable because it was required to make a Detector, and that is no longer the case.

            I have attached my attempted update of testUtils.py in case it is a useful starting point.
            Please update the cbp package for change in how Detectors and Cameras are built.

            I suggest you use the tickets/DM-20488 branch or base your branch off of that one. Or, if you prefer, cherry-pick those changes.

            I think the main class that needs updating is SampleCoordinateConverter in testUtils.py.
            I had a try at this myself (see attached file), and was able to make a list of Detectors and get rid of the no-longer-needed AmpInfoTable (the test code doesn't care about amplifiers), but could not figure out how to create a Camera (nor verify that the Detectors I made were correct).
            swinbank John Swinbank made changes -
            Epic Link DM-22588 [ 427655 ]
            ktl Kian-Tat Lim made changes -
            Link This issue is triggered by RFC-658 [ RFC-658 ]
            swinbank John Swinbank made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            swinbank John Swinbank made changes -
            Reviewers Russell Owen [ rowen ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            swinbank John Swinbank made changes -
            Team DM Science [ 12218 ] Alert Production [ 10300 ]
            swinbank John Swinbank made changes -
            Epic Link DM-22588 [ 427655 ] DM-22484 [ 427311 ]
            rowen Russell Owen made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            swinbank John Swinbank made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            swinbank John Swinbank made changes -
            Link This issue blocks DM-23830 [ DM-23830 ]
            swinbank John Swinbank made changes -
            Epic Link DM-22484 [ 427311 ] DM-24339 [ 433026 ]
            swinbank John Swinbank made changes -
            Epic Link DM-24339 [ 433026 ] DM-23740 [ 431397 ]
            swinbank John Swinbank made changes -
            Assignee Merlin Fisher-Levine [ mfisherlevine ] John Swinbank [ swinbank ]
            swinbank John Swinbank made changes -
            Epic Link DM-23740 [ 431397 ] DM-22484 [ 427311 ]

              People

              Assignee:
              swinbank John Swinbank
              Reporter:
              rowen Russell Owen
              Reviewers:
              Russell Owen
              Watchers:
              John Swinbank, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.