Details

    • Type: Technical task
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_base
    • Labels:
      None
    • Story Points:
      3
    • Sprint:
      Science Pipelines DM-S15-1, Science Pipelines DM-S15-2
    • Team:
      Data Release Production

      Description

      Provide calibration transforms for flux measurements to magnitudes.

        Attachments

          Activity

          Hide
          swinbank John Swinbank added a comment -

          Hi Lauren – do you have time for a review of this, please?

          The aim here is to exploit the "transformation framework" (see DM-1074) to provide a consistent means of converting fluxes to magnitudes across all our different measurement algorithms.

          In the process of making this work, I also did some editing of the meas_base test suite to make it more idiomatic: I hope ultimately this makes everybody's life easier, but it does cause rather a lot of code churn in this ticket.

          All changes are on tickets/DM-2305 in meas_base.

          Show
          swinbank John Swinbank added a comment - Hi Lauren – do you have time for a review of this, please? The aim here is to exploit the "transformation framework" (see DM-1074 ) to provide a consistent means of converting fluxes to magnitudes across all our different measurement algorithms. In the process of making this work, I also did some editing of the meas_base test suite to make it more idiomatic: I hope ultimately this makes everybody's life easier, but it does cause rather a lot of code churn in this ticket. All changes are on tickets/DM-2305 in meas_base .
          Hide
          swinbank John Swinbank added a comment -

          Hi Paul – I asked Lauren to take a look at this, but she's snowed under for the next week or two. Do you have time for a review? See the previous comment for some background, and feel free to send it back to me if you are also busy.

          Show
          swinbank John Swinbank added a comment - Hi Paul – I asked Lauren to take a look at this, but she's snowed under for the next week or two. Do you have time for a review? See the previous comment for some background, and feel free to send it back to me if you are also busy.
          Hide
          price Paul Price added a comment -

          Review completed on github: https://github.com/lsst/meas_base/pull/10

          Only major concern is the change with namespaces that prompted RFC-34. Everything else is nitpicky.

          Show
          price Paul Price added a comment - Review completed on github: https://github.com/lsst/meas_base/pull/10 Only major concern is the change with namespaces that prompted RFC-34 . Everything else is nitpicky.
          Hide
          swinbank John Swinbank added a comment -

          Thanks Paul!

          Show
          swinbank John Swinbank added a comment - Thanks Paul!

            People

            • Assignee:
              swinbank John Swinbank
              Reporter:
              swinbank John Swinbank
              Reviewers:
              Paul Price
              Watchers:
              John Swinbank, Lauren MacArthur, Paul Price
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel