Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-23056

Suppress FutureWarnings from LSST code

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • afw
    • None

    Description

      Since DM-17566 landed, we're generating a bunch of FutureWarnings from inside DM code. Please suppress them.

      Attachments

        Issue Links

          Activity

            swinbank John Swinbank added a comment - Relevant discussion: https://lsstc.slack.com/archives/C2JPMCF5X/p1578508323001300

            Pretty sure https://github.com/lsst/afw/commit/faee97bfb0ffc3f1b1624ba88f72181b3955ea5f will take care of this when reading backgrounds. Tracking down all of the other possible warnings might take some work, though.

            swinbank John Swinbank added a comment - Pretty sure https://github.com/lsst/afw/commit/faee97bfb0ffc3f1b1624ba88f72181b3955ea5f will take care of this when reading backgrounds. Tracking down all of the other possible warnings might take some work, though.

            erykoff, I can try spinning up my own processCcd and looking for warnings, but I'm unlikely to have time in the immediate future. If you have a list of things that are bothering you/DESC/whoever, post it here and I'll clear them up quickly.

            swinbank John Swinbank added a comment - erykoff , I can try spinning up my own processCcd and looking for warnings, but I'm unlikely to have time in the immediate future. If you have a list of things that are bothering you/DESC/whoever, post it here and I'll clear them up quickly.
            erykoff Eli Rykoff added a comment - The other warning that I see comes from here: https://github.com/lsst/meas_algorithms/blob/3d9e4fb20c9f35e8f606303a663b75f74ef65250/python/lsst/meas/algorithms/detection.py#L701

            Hi Eli — if you can do a quick review of this, we can get it in for the next weekly...

            For whatever reason, Jira is only picking up 3 PRs when I write this, but there are actually four:

            With these changes, I see no FutureWarning​s from running all of the tests in meas_algorithms or pipe_tasks, which includes the warnings you linked to above and a bunch of others. I can't promise that this covers every FutureWarning which might be generated in the codebase, of course, but it's probably good enough for now.

            Unfortunately, Jenkins is currently down, so I can't show that this didn't break anything. However, all the tests run locally for me.

            swinbank John Swinbank added a comment - Hi Eli — if you can do a quick review of this, we can get it in for the next weekly... For whatever reason, Jira is only picking up 3 PRs when I write this, but there are actually four: https://github.com/lsst/afw/pull/508 https://github.com/lsst/utils/pull/79 https://github.com/lsst/meas_algorithms/pull/189 https://github.com/lsst/pipe_tasks/pull/342 With these changes, I see no FutureWarning ​s from running all of the tests in meas_algorithms or pipe_tasks, which includes the warnings you linked to above and a bunch of others. I can't promise that this covers every FutureWarning which might be generated in the codebase, of course, but it's probably good enough for now. Unfortunately, Jenkins is currently down, so I can't show that this didn't break anything. However, all the tests run locally for me.

            Didn't make it in for w_2020_03 because I didn't want to merge without Jenkins. Now running at https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/31057/pipeline.

            swinbank John Swinbank added a comment - Didn't make it in for w_2020_03 because I didn't want to merge without Jenkins. Now running at https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/31057/pipeline .

            People

              swinbank John Swinbank
              swinbank John Swinbank
              Eli Rykoff
              Eli Rykoff, John Swinbank
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.