Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-23062

Preserve input headers

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_base
    • Labels:
    • Team:
      External

      Description

      RFC-576 established that we would propagate all input headers to the output files. This feature is desired for the next HSC production run.

        Attachments

          Activity

          Hide
          price Paul Price added a comment -

          I think a small change in obs_base was sufficient. I've verified that this is enough to restore the missing header keywords to the calexp. Tim Jenness, would you mind reviewing this, please?

          Show
          price Paul Price added a comment - I think a small change in obs_base was sufficient. I've verified that this is enough to restore the missing header keywords to the calexp . Tim Jenness , would you mind reviewing this, please?
          Hide
          price Paul Price added a comment -

          No, I take it back. There's a test failure that needs fixing first. Sorry!

          Show
          price Paul Price added a comment - No, I take it back. There's a test failure that needs fixing first. Sorry!
          Hide
          price Paul Price added a comment -

          Fixed. Ready for review again, please.

          Show
          price Paul Price added a comment - Fixed. Ready for review again, please.
          Hide
          tjenness Tim Jenness added a comment -

          Looks good. One comment on the PR relating to non-ObservationInfo obs packages that I think will need fixing.

          Show
          tjenness Tim Jenness added a comment - Looks good. One comment on the PR relating to non-ObservationInfo obs packages that I think will need fixing.
          Hide
          price Paul Price added a comment -

          OK, doing it slightly differently now (switch via Ctor rather than __call__). Do you want to have another look?

          Show
          price Paul Price added a comment - OK, doing it slightly differently now (switch via Ctor rather than __call__ ). Do you want to have another look?
          Hide
          tjenness Tim Jenness added a comment -

          Looks good to me.

          Show
          tjenness Tim Jenness added a comment - Looks good to me.
          Hide
          price Paul Price added a comment -
          Show
          price Paul Price added a comment - Jenkins is green .
          Hide
          price Paul Price added a comment -

          Merged to master.

          Thanks for all your help, Tim Jenness!

          Show
          price Paul Price added a comment - Merged to master. Thanks for all your help, Tim Jenness !

            People

            • Assignee:
              price Paul Price
              Reporter:
              price Paul Price
              Reviewers:
              Tim Jenness
              Watchers:
              Paul Price, Tim Jenness
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: