Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-23080

Move dimension Registry code into helper classes

    Details

      Description

      This implements the DimensionTableRecords and DimensionTableManager classes described in the prototype document.

        Attachments

          Issue Links

            Activity

            Hide
            jbosch Jim Bosch added a comment -

            Nate Lust, I've drawn your name again on the Registry review list.  This one is almost purely refactoring - one commit cleans up some edge cases, too.  Please review commit-by-commit and look at the comments to see what's worth looking at closely and what isn't; the bigger changes in terms of line numbers are mostly just moving code around without changing it.

            All changes are in daf_butler.

            The motivation for some of these changes may not be apparent just looking at the diffs.  Basically, it's updating an early version of these Registry helper classes to be more consistent with a much more complete system of Registry helper classes described on this confluence page.  I don't think that's required reading for the review, but it may be useful if you're curious why I felt something was worth changing.

            Show
            jbosch Jim Bosch added a comment - Nate Lust , I've drawn your name again on the Registry review list.  This one is almost purely refactoring - one commit cleans up some edge cases, too.  Please review commit-by-commit and look at the comments to see what's worth looking at closely and what isn't; the bigger changes in terms of line numbers are mostly just moving code around without changing it. All changes are in daf_butler . The motivation for some of these changes may not be apparent just looking at the diffs.  Basically, it's updating an early version of these Registry helper classes to be more consistent with a much more complete system of Registry helper classes described on this confluence page .  I don't think that's required reading for the review, but it may be useful if you're curious why I felt something was worth changing.
            Hide
            nlust Nate Lust added a comment -

            Some comments, otherwise good.

            Show
            nlust Nate Lust added a comment - Some comments, otherwise good.

              People

              • Assignee:
                jbosch Jim Bosch
                Reporter:
                jbosch Jim Bosch
                Reviewers:
                Nate Lust
                Watchers:
                Jim Bosch, Nate Lust
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel