Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-23105

Fixups for Spectractor

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • None
    • None
    • 6
    • Data Release Production
    • No

    Description

      Having resynced with master, this ticket is for any fixups or additions.

      Not done as part of DM-23093 to make filing PRs to the upstream easier.

      Attachments

        Activity

          Having installed all dependencies and made some fixups, all tests now pass on lsst-dev. I've patched the travis config, and it's working a lot better there, but is still not technically returning a clean build yet.

          However, upstream has moved on, so I'm merging this so that I can pull in those changes, and then fix everything required all in one go.

          I've agreed with Jérémy that I bring in his latest changes, and then we both work against a new branch called AuxTel (though we'll have different names on each side) with no more changes to master while we get the AuxTel stuff working.

          mfisherlevine Merlin Fisher-Levine added a comment - Having installed all dependencies and made some fixups, all tests now pass on lsst-dev. I've patched the travis config, and it's working a lot better there, but is still not technically returning a clean build yet. However, upstream has moved on, so I'm merging this so that I can pull in those changes, and then fix everything required all in one go. I've agreed with Jérémy that I bring in his latest changes, and then we both work against a new branch called AuxTel (though we'll have different names on each side) with no more changes to master while we get the AuxTel stuff working.

          Looks like Jérémy has cherry picked some of these commits (I think by hand rather than with git), so I'm not going to merge this ticket. What I will do is keep it so that I've got the commits to look at, merge his new master in (using a different ticket) and then cherry pick any of these I want later). Will mark as Invalid once I'm done with it.

          mfisherlevine Merlin Fisher-Levine added a comment - Looks like Jérémy has cherry picked some of these commits (I think by hand rather than with git), so I'm not going to merge this ticket. What I will do is keep it so that I've got the commits to look at, merge his new master in (using a different ticket) and then cherry pick any of these I want later). Will mark as Invalid once I'm done with it.

          Given that this work was done, and the changes either have, or will make it in, I think Done is more correct than Invalid, given it will have SP attached.

          mfisherlevine Merlin Fisher-Levine added a comment - Given that this work was done, and the changes either have, or will make it in, I think Done is more correct than Invalid, given it will have SP attached.

          People

            mfisherlevine Merlin Fisher-Levine
            mfisherlevine Merlin Fisher-Levine
            Christopher Waters, Merlin Fisher-Levine
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Jenkins

                No builds found.