Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-2312

obs_test's table file is out of date

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_test
    • Labels:
      None
    • Story Points:
      1
    • Sprint:
      Science Pipelines DM-S15-4
    • Team:
      Alert Production

      Description

      obs_test's table file is somewhat out of date. Problems include:

      • afw is required but missing
      • meas_algorithms and skypix are used by bin/genInputRegistry.py, which is only used to create the input repo so these can be optional
      • daf_persistence is not used
      • daf_base is only used by bin/genInputRegistry.py, so it can be optional (though it is presumably setup by daf_butlerUtils in any case)

        Attachments

          Activity

          Hide
          rowen Russell Owen added a comment -

          Would you have time to look at this? The work is on obs_test on tickets/DM-2312 and consists of minor changes to the EUPS table file and adding a comment to a help string in a utility script.

          Show
          rowen Russell Owen added a comment - Would you have time to look at this? The work is on obs_test on tickets/ DM-2312 and consists of minor changes to the EUPS table file and adding a comment to a help string in a utility script.
          Hide
          jhoblitt Joshua Hoblitt added a comment -

          meas_algorithms isn't added to the table file, was that intentional?

          I see imports of numpy, pyfits, ip_isr, & utils that aren't reflected in the table file. That later is included in tickets/DM-2636.

          I also think that the table file should require scons and sconsUtils since they are hard dependencies.

          Show
          jhoblitt Joshua Hoblitt added a comment - meas_algorithms isn't added to the table file, was that intentional? I see imports of numpy, pyfits, ip_isr, & utils that aren't reflected in the table file. That later is included in tickets/ DM-2636 . I also think that the table file should require scons and sconsUtils since they are hard dependencies.
          Hide
          rowen Russell Owen added a comment -

          Thank you for noticing that numpy and utils were missing. I will add those.

          Regarding ip_isr, pyfits and meas_algorithms: those were intentionally omitted. They are used by the scripts in data/utils, but these scripts are only used to generate the data and so are not needed by any user of the package. As such, I decided to document their use rather than add needless extra dependencies. In fact in some cases, such as meas_algorithms, the dependency cannot be added to the eups table file because it would create a circular dependency, which breaks buildbot (as I found out the hard way). I discussed it with K-T and he suggested documenting the dependencies; he pointed out that I could create another package to contain these scripts, but we both felt that was too heavyweight.

          Regarding scons and sconsUtils: I could not find any package that lists those, other than sconsUtils and lsst_thirdparty.

          Show
          rowen Russell Owen added a comment - Thank you for noticing that numpy and utils were missing. I will add those. Regarding ip_isr, pyfits and meas_algorithms: those were intentionally omitted. They are used by the scripts in data/utils, but these scripts are only used to generate the data and so are not needed by any user of the package. As such, I decided to document their use rather than add needless extra dependencies. In fact in some cases, such as meas_algorithms, the dependency cannot be added to the eups table file because it would create a circular dependency, which breaks buildbot (as I found out the hard way). I discussed it with K-T and he suggested documenting the dependencies; he pointed out that I could create another package to contain these scripts, but we both felt that was too heavyweight. Regarding scons and sconsUtils: I could not find any package that lists those, other than sconsUtils and lsst_thirdparty.
          Hide
          jhoblitt Joshua Hoblitt added a comment -

          If RFC-52 is adopted, scons and sconsUtils should be listed. We will have at least java and javascript as part of the stack that will most likely not use either of those.

          Show
          jhoblitt Joshua Hoblitt added a comment - If RFC-52 is adopted, scons and sconsUtils should be listed. We will have at least java and javascript as part of the stack that will most likely not use either of those.
          Hide
          rowen Russell Owen added a comment - - edited

          Josh: could you please note your concerns about scons and sconsUtils in RFC-52? It may be controversial and certainly deserves discussion.

          Show
          rowen Russell Owen added a comment - - edited Josh: could you please note your concerns about scons and sconsUtils in RFC-52 ? It may be controversial and certainly deserves discussion.
          Hide
          rowen Russell Owen added a comment -

          I made the other changes, squashed the commit and greatly improved the git commit message. Please take another look and close the review if you are ready.

          Show
          rowen Russell Owen added a comment - I made the other changes, squashed the commit and greatly improved the git commit message. Please take another look and close the review if you are ready.

            People

            • Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Joshua Hoblitt
              Watchers:
              Joshua Hoblitt, Russell Owen
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel