Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-23159

Make PTC task compatible with RFC-352

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Make the PTC measurement task compatible with RFC-352, and move all the algorithmic code to a Task.run() method which returns to the Task.runDataRef() all the products to be saved. This would move all the dataRef.get() and dataRef.put() code to runDataRef(), letting run() operate only on python objects. The benefit of this is that gen3 conversion is then much easier (and can focus on gen3/middleware code instead of algorithmic code).

        Attachments

          Issue Links

            Activity

            Hide
            nlust Nate Lust added a comment -

            Comments are up in cp_pipe

            Show
            nlust Nate Lust added a comment - Comments are up in cp_pipe
            Hide
            nlust Nate Lust added a comment -

            Thanks for the changes. Overall looks fine, I get why you would want to keep code similar to what you ported from for now. A few minor comments. I will ask that you file a ticket describing what work you want to do next to clean things up or reorganize and what the plan to do that will be, even if that does not occur until you get rid of gen2 support. This will help make sure nothing falls through the cracks.

            Show
            nlust Nate Lust added a comment - Thanks for the changes. Overall looks fine, I get why you would want to keep code similar to what you ported from for now. A few minor comments. I will ask that you file a ticket describing what work you want to do next to clean things up or reorganize and what the plan to do that will be, even if that does not occur until you get rid of gen2 support. This will help make sure nothing falls through the cracks.
            Hide
            nlust Nate Lust added a comment -

            I took myself off reviewer list

            Show
            nlust Nate Lust added a comment - I took myself off reviewer list
            Hide
            plazas Andrés Alejandro Plazas Malagón added a comment -

            We had to run Jenkins with only ci_cpp_gen3 due to a ci_cpp_gen2 problem with the mac build: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/33396/

            But, I was able to successfully build ci_cpp_gen2: ci_cpp_gen2_output_2021JAN20.txt

            Show
            plazas Andrés Alejandro Plazas Malagón added a comment - We had to run Jenkins with only ci_cpp_gen3 due to a ci_cpp_gen2 problem with the mac build: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/33396/ But, I was able to successfully build ci_cpp_gen2 : ci_cpp_gen2_output_2021JAN20.txt
            Hide
            plazas Andrés Alejandro Plazas Malagón added a comment -

            Future PTC work: DM-28588

            Show
            plazas Andrés Alejandro Plazas Malagón added a comment - Future PTC work: DM-28588

              People

              Assignee:
              plazas Andrés Alejandro Plazas Malagón
              Reporter:
              plazas Andrés Alejandro Plazas Malagón
              Reviewers:
              Christopher Waters
              Watchers:
              Andrés Alejandro Plazas Malagón, Christopher Waters, Nate Lust
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  CI Builds

                  No builds found.