Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-23159

Make PTC task compatible with RFC-352

    Details

    • Type: Story
    • Status: In Progress
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Make the PTC measurement task compatible with RFC-352, and move all the algorithmic code to a Task.run() method which returns to the Task.runDataRef() all the products to be saved. This would move all the dataRef.get() and dataRef.put() code to runDataRef(), letting run() operate only on python objects. The benefit of this is that gen3 conversion is then much easier (and can focus on gen3/middleware code instead of algorithmic code).

        Attachments

          Issue Links

            Activity

            Hide
            plazas Andrés Alejandro Plazas Malagón added a comment - - edited

            Suggestion by C. Waters:

            • L339-356 move to a run method, which is the "algorithmic" section. The idea being that run( list(postISRCCD), config) yields Struct(plots=list(ptcFitPlots), ptcDataset=dataset, linearizer=LinearizerLookupTable, etcDataToSave=somethingElse) , which runDataRef then calls butler.put on.
            Show
            plazas Andrés Alejandro Plazas Malagón added a comment - - edited Suggestion by C. Waters: Move the dataset into a new run() method, that expects a list of ISR processed exposures, and returns a struct containing all of the output products that will be written to disk. L328-337 ( https://github.com/lsst/cp_pipe/blob/tickets/DM-21221/python/lsst/cp/pipe/ptc.py ) stay in runDataRef, as they're doing the ISR processing to generate the postISRCCD files that will be passed to run. L339-356 move to a run method, which is the "algorithmic" section. The idea being that run( list(postISRCCD), config) yields Struct(plots=list(ptcFitPlots), ptcDataset=dataset, linearizer=LinearizerLookupTable, etcDataToSave=somethingElse) , which runDataRef then calls butler.put on.

              People

              • Assignee:
                plazas Andrés Alejandro Plazas Malagón
                Reporter:
                plazas Andrés Alejandro Plazas Malagón
                Watchers:
                Andrés Alejandro Plazas Malagón, Christopher Waters, John Swinbank
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Summary Panel