Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-23174

Consolidate daf_butler test code

    Details

      Description

      On pipe_base#114, Tim Jenness requested:

      I really think that the test code for creating butlers and dataset types should be moved to daf_butler. daf_butler already has some of these functions in the helper packages inside daf_butler tests directory but it seems that they need to be consolidated with your code here and moved to lsst.daf.butler.tests.

      Create a daf.butler.tests module and reorganize the existing helper code as described. Note that the unit tests inside daf_butler (i.e., tests of the butler) and the unit tests supported by pipe.base.tests (i.e., tests with the butler) are slightly different use cases; the former requires much more familiarity with the Gen 3 butler than the latter.

        Attachments

          Issue Links

            Activity

            Hide
            krzys Krzysztof Findeisen added a comment - - edited

            Tim Jenness, in your comment were you talking about datasetsHelper, dummyRegistry, and examplePythonTypes? While it looks relevant to testing (and examplePythonTypes would have been useful for testing the code added in DM-22599), I don't see anything for setting up test repositories and the like.

            Show
            krzys Krzysztof Findeisen added a comment - - edited Tim Jenness , in your comment were you talking about datasetsHelper , dummyRegistry , and examplePythonTypes ? While it looks relevant to testing (and examplePythonTypes would have been useful for testing the code added in DM-22599 ), I don't see anything for setting up test repositories and the like.
            Hide
            tjenness Tim Jenness added a comment -

            We do not have the equivalent of your test repo code since we mainly call makeRepo in setUp and then have each test populate the dimensions. We do have code for making quick dataset types though and it's clear that people would benefit from some of these internal functions and your new test code being a public API for daf_butler.

            Show
            tjenness Tim Jenness added a comment - We do not have the equivalent of your test repo code since we mainly call makeRepo in setUp and then have each test populate the dimensions. We do have code for making quick dataset types though and it's clear that people would benefit from some of these internal functions and your new test code being a public API for daf_butler.
            Hide
            krzys Krzysztof Findeisen added a comment -

            (Please disregard my previous question – I double-checked and the makeQuantum UI has an IMO useful dependency on PipelineTask).

            Show
            krzys Krzysztof Findeisen added a comment - (Please disregard my previous question – I double-checked and the makeQuantum UI has an IMO useful dependency on PipelineTask ).
            Hide
            krzys Krzysztof Findeisen added a comment -

            Hi Tim Jenness, can you take a look at this? In particular, if I'm still misusing or duplicating any existing daf_butler functionality, that would be good to know.

            Show
            krzys Krzysztof Findeisen added a comment - Hi Tim Jenness , can you take a look at this? In particular, if I'm still misusing or duplicating any existing daf_butler functionality, that would be good to know.

              People

              • Assignee:
                krzys Krzysztof Findeisen
                Reporter:
                krzys Krzysztof Findeisen
                Reviewers:
                Tim Jenness
                Watchers:
                Jim Bosch, John Swinbank, Krzysztof Findeisen, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel