Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-23238

Add per row overscan removal

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Add per-row median overscan subtraction as an isr config option. Use special casing for handing ints.

        Attachments

          Activity

          Hide
          plazas Andrés Alejandro Plazas Malagón added a comment -

          Things are ready, but the jenkins problems are holding the merge.

          Show
          plazas Andrés Alejandro Plazas Malagón added a comment - Things are ready, but the jenkins problems are holding the merge.
          Hide
          mfisherlevine Merlin Fisher-Levine added a comment -

          You got lucky and had 1 of 2 builds pass. Especially as these are python only changes, you're good to merge

          Show
          mfisherlevine Merlin Fisher-Levine added a comment - You got lucky and had 1 of 2 builds pass. Especially as these are python only changes, you're good to merge
          Hide
          mfisherlevine Merlin Fisher-Levine added a comment -

          Btw, although this is OK this one time, given that Jenkins is known to be very sad right now, and this failure is nowhere near the changes, what I said is probably legit, but this is very much not a general rule. All Jenkins failures should be taken seriously in general.

          Show
          mfisherlevine Merlin Fisher-Levine added a comment - Btw, although this is OK this one time, given that Jenkins is known to be very sad right now, and this failure is nowhere near the changes, what I said is probably legit, but this is very much not a general rule. All Jenkins failures should be taken seriously in general.
          Hide
          plazas Andrés Alejandro Plazas Malagón added a comment -

          OK. Where did you see that 1 of 2 builds passed?

          Show
          plazas Andrés Alejandro Plazas Malagón added a comment - OK. Where did you see that 1 of 2 builds passed?
          Hide
          czw Christopher Waters added a comment -

          https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/31224/pipeline/

          The failure looks unrelated to your code, and the mac build is completely broken.  I've launched a build of master (https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/31229/pipeline) to try and get an independent view on "is something broken".

          Show
          czw Christopher Waters added a comment - https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/31224/pipeline/ The failure looks unrelated to your code, and the mac build is completely broken.  I've launched a build of master ( https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/31229/pipeline ) to try and get an independent view on "is something broken".

            People

            • Assignee:
              plazas Andrés Alejandro Plazas Malagón
              Reporter:
              mfisherlevine Merlin Fisher-Levine
              Reviewers:
              Christopher Waters
              Watchers:
              Andrés Alejandro Plazas Malagón, Christopher Waters, John Swinbank, Merlin Fisher-Levine, Robert Lupton
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel