Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: meas_base, pipe_tasks
-
Labels:
-
Team:External
-
Urgent?:No
Description
forcedPhotCcd needs to be able to apply the jointcal/fgcm and skyCorr recalibrations. Because this matches logic elsewhere in the pipeline (MakeCoaddTempExpTask), this will involve some refactoring, and because it involves I/O, we need to keep Gen3 happy.
Attachments
Issue Links
- relates to
-
- To Do
Activity
OK, I think this is ready for another look. Packages of interest:
I'm leaving off packages that you've already signed off on and I didn't change (e.g., pex_config, daf_butler; obs_lsst goes away).
Paul Price
added a comment - OK, I think this is ready for another look. Packages of interest:
meas_base
pipe_tasks
ci_hsc_gen2
ci_hsc_gen3
obs_base
obs_subaru
I'm leaving off packages that you've already signed off on and I didn't change (e.g., pex_config, daf_butler; obs_lsst goes away). Looks good. I'm sorry it's been such an ordeal to get here. I haven't tried to follow the logic of whether we should worry about MakeWarpTask trying and failing to apply recalibrations in ci_hsc_gen3, but Jenkins will take care of that.
Jenkins is green. I'll be merging soon.
Paul Price
added a comment - Jenkins is green . I'll be merging soon. Merged to master. Thanks to everyone for their patience, and especially to Jim and Nate for bearing with my many questions about Gen3.
Paul Price
added a comment - Merged to master. Thanks to everyone for their patience, and especially to Jim and Nate for bearing with my many questions about Gen3. 
So it looks like the config-churning changes have been aborted. While I am always willing to adapt to major/backward-incompatible changes when there’s significant/unavoidable immediate &/or forward-looking gain, that didn’t appear to obviously be the case here. Having just spent an entire day towards adapting the pipe_analysis scripts to the new “external” calibration config names of
DM-21308, I’ll just say “phew”