Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-23369

Remove lsst.ip.isr.addDistortionModel

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ip_isr
    • Labels:
      None
    • Story Points:
      1
    • Sprint:
      AP S20-5 (April)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      lsst.ip.isr.addDistortionModel was announced as deprecated in release 19.0.0 on DM-20154. Remove it before release 20.0.0.

        Attachments

          Issue Links

            Activity

            Hide
            swinbank John Swinbank added a comment -

            Hey John — got a moment to look at this?

            Two PRs, properly linked by Jira.

            Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/31670/pipeline

            Show
            swinbank John Swinbank added a comment - Hey John — got a moment to look at this? Two PRs, properly linked by Jira. Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/31670/pipeline
            Hide
            Parejkoj John Parejko added a comment -

            The PRs each have a question, and I think the questions are related, but I'm not sure.

            Did the jenkins run have ci_hsc? I know I've tripped over this deprecation warning semi-recently somewhere.

            Show
            Parejkoj John Parejko added a comment - The PRs each have a question, and I think the questions are related, but I'm not sure. Did the jenkins run have ci_hsc? I know I've tripped over this deprecation warning semi-recently somewhere.
            Hide
            swinbank John Swinbank added a comment -

            Thanks John Parejko. I've reworked the change on obs_cfht to remove the camera parameter entirely. I've also rerun Jenkins ensuring ci_hsc is included: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/31726/pipeline/. I'll merge this to master, and file a ticket to ask for somebody to clean up IsrTask's camera parameter.

            Show
            swinbank John Swinbank added a comment - Thanks John Parejko . I've reworked the change on obs_cfht to remove the camera parameter entirely. I've also rerun Jenkins ensuring ci_hsc is included: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/31726/pipeline/ . I'll merge this to master, and file a ticket to ask for somebody to clean up IsrTask 's camera parameter.
            Hide
            swinbank John Swinbank added a comment -

            Follow-up ticket DM-24680.

            Show
            swinbank John Swinbank added a comment - Follow-up ticket DM-24680 .

              People

              • Assignee:
                swinbank John Swinbank
                Reporter:
                swinbank John Swinbank
                Reviewers:
                John Parejko
                Watchers:
                John Parejko, John Swinbank
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel