[DM-23369] Remove lsst.ip.isr.addDistortionModel - Jira

XML

Word

Printable

Details

Type: Story
Status: Done
Resolution: Done
Fix Version/s: None
Component/s: ip_isr
Labels:
None

Story Points:
1
Epic Link:
s20b-ap-emergent
Sprint:
AP S20-5 (April)
Team:
Alert Production
Urgent?:
No

Description

lsst.ip.isr.addDistortionModel was announced as deprecated in release 19.0.0 on ~~DM-20154~~. Remove it before release 20.0.0.

Attachments

Issue Links

blocks

DM-20564 Do release 20.0.0 of science pipelines

Done

is blocked by

DM-23651 ap_pipe calls some deprecated things

Done

mentioned in: Page Loading...; Page Loading...; Page Loading...; Page Loading...; Page Loading...; Page Loading...; Page Loading...; Page Loading...; Page Loading...

(6 mentioned in)

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

John Swinbank added a comment - 25/Apr/20 12:21 AM

Hey John — got a moment to look at this?

Two PRs, properly linked by Jira.

Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/31670/pipeline

Show

John Swinbank added a comment - 25/Apr/20 12:21 AM Hey John — got a moment to look at this? Two PRs, properly linked by Jira. Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/31670/pipeline

Hide

Permalink

John Parejko added a comment - 27/Apr/20 7:32 PM

The PRs each have a question, and I think the questions are related, but I'm not sure.

Did the jenkins run have ci_hsc? I know I've tripped over this deprecation warning semi-recently somewhere.

Show

John Parejko added a comment - 27/Apr/20 7:32 PM The PRs each have a question, and I think the questions are related, but I'm not sure. Did the jenkins run have ci_hsc? I know I've tripped over this deprecation warning semi-recently somewhere.

Hide

Permalink

John Swinbank added a comment - 29/Apr/20 10:37 PM

Thanks John Parejko. I've reworked the change on obs_cfht to remove the camera parameter entirely. I've also rerun Jenkins ensuring ci_hsc is included: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/31726/pipeline/. I'll merge this to master, and file a ticket to ask for somebody to clean up IsrTask's camera parameter.

Show

John Swinbank added a comment - 29/Apr/20 10:37 PM Thanks John Parejko . I've reworked the change on obs_cfht to remove the camera parameter entirely. I've also rerun Jenkins ensuring ci_hsc is included: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/31726/pipeline/ . I'll merge this to master, and file a ticket to ask for somebody to clean up IsrTask 's camera parameter.

Hide

Permalink

John Swinbank added a comment - 29/Apr/20 10:40 PM

Follow-up ticket DM-24680.

Show

John Swinbank added a comment - 29/Apr/20 10:40 PM Follow-up ticket DM-24680 .

People

Assignee:: John Swinbank

Reporter:: John Swinbank

Reviewers:: John Parejko

Watchers:: John Parejko, John Swinbank

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 06/Feb/20 10:05 PM

Updated:: 29/Apr/20 10:40 PM

Resolved:: 29/Apr/20 10:40 PM

Jenkins

No builds found.

Data Management

Details

Description

Attachments

Issue Links

Activity

People

Dates

Jenkins