Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-23436

apdb creation instructions outdated

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Yusra AlSayyad on Slack:

      Hi, is https://github.com/lsst/ap_pipe/blob/master/doc/lsst.ap.pipe/apdb.rst up to date? I’m getting 'ApPipeConfig' object has no attribute 'apdb' and make_apdb.py: error: no config field: apdb.db_url

        Attachments

          Issue Links

          is duplicated by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-18017 Update ap_pipe docs to reflect new ppdb configs

          • Invalid
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-22741 Remove ap_association subtasks from ap_pipe. Change to single DiaPipelineTask subtask.

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            As part of this ticket, we noticed that we need to add lsst-pipelinetasks:: sections to the docs on both ap_association and ip_diffim.

            Show
            swinbank John Swinbank added a comment - As part of this ticket, we noticed that we need to add lsst-pipelinetasks:: sections to the docs on both ap_association and ip_diffim.
            Hide
            Permalink
            swinbank John Swinbank added a comment - - edited

            Hi Krzysztof Findeisen — per Slack, would you mind taking a look at this please?

            Jira has correctly identified the 3 branches on ip_diffim, ap_pipe, and ap_association.

            Show
            swinbank John Swinbank added a comment - - edited Hi Krzysztof Findeisen — per Slack, would you mind taking a look at this please? Jira has correctly identified the 3 branches on ip_diffim, ap_pipe, and ap_association.
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment - - edited

            I have some concerns about the reworded apdb.rst that I'd like to see addressed. All the more structural changes look good, though.

            Show
            krzys Krzysztof Findeisen added a comment - - edited I have some concerns about the reworded apdb.rst that I'd like to see addressed. All the more structural changes look good, though.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Thanks for the thoughtful comments. Please take another look and see if you're now happier.

            Show
            swinbank John Swinbank added a comment - Thanks for the thoughtful comments. Please take another look and see if you're now happier.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            (Worth adding that I added a couple of extra fixups on the ap_pipe ticket — removing bad information from README.md, and fixing commands in pipeline-tutorial.rst that I missed previously.)

            Show
            swinbank John Swinbank added a comment - (Worth adding that I added a couple of extra fixups on the ap_pipe ticket — removing bad information from README.md , and fixing commands in pipeline-tutorial.rst that I missed previously.)
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            Looks good to me, thanks for going back and rewording!

            Show
            krzys Krzysztof Findeisen added a comment - Looks good to me, thanks for going back and rewording!
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Thanks! Merged.

            Show
            swinbank John Swinbank added a comment - Thanks! Merged.

              People

              Assignee:
              swinbank John Swinbank
              Reporter:
              swinbank John Swinbank
              Reviewers:
              Krzysztof Findeisen
              Watchers:
              John Swinbank, Krzysztof Findeisen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.