Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-23539

Incorporate Rowe statistics

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Story Points:
      21
    • Epic Link:
    • Sprint:
      DRP S20-3 (Feb), DRP S20-5 (Apr), DRP S20-6 (May), DRP F20-1 (June)
    • Team:
      Data Release Production
    • Urgent?:
      No

      Description

      Plot all 5 Rowe statistics involving correlation functions of PSF shape and/or size residuals.

        Attachments

          Issue Links

            Activity

            kannawad Arun Kannawadi created issue -
            kannawad Arun Kannawadi made changes -
            Field Original Value New Value
            Epic Link DM-22590 [ 427657 ]
            kannawad Arun Kannawadi made changes -
            Link This issue blocks DM-3040 [ DM-3040 ]
            kannawad Arun Kannawadi made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            kannawad Arun Kannawadi made changes -
            Link This issue contains DM-3040 [ DM-3040 ]
            kannawad Arun Kannawadi made changes -
            Link This issue blocks DM-3040 [ DM-3040 ]
            yusra Yusra AlSayyad made changes -
            Story Points 16
            yusra Yusra AlSayyad made changes -
            Story Points 16
            yusra Yusra AlSayyad made changes -
            Epic Link DM-22590 [ 427657 ] DM-23741 [ 431398 ]
            kannawad Arun Kannawadi made changes -
            Status In Progress [ 3 ] To Do [ 10001 ]
            kannawad Arun Kannawadi made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            yusra Yusra AlSayyad made changes -
            Sprint DRP S20-3 (Feb) [ 1000 ] DRP S20-3 (Feb), DRP S20-5 (Apr) [ 1000, 1014 ]
            Hide
            kannawad Arun Kannawadi added a comment -

            The PR is to incorporate calculation of Rho/Rowe statistics as a part of regular QA processing. Requesting 2 reviews - for content and integration with pipe_analysis

            Show
            kannawad Arun Kannawadi added a comment - The PR is to incorporate calculation of Rho/Rowe statistics as a part of regular QA processing. Requesting 2 reviews - for content and integration with pipe_analysis
            kannawad Arun Kannawadi made changes -
            Reviewers Morgan Schmitz, Sophie Reed [ mschmitz, sophiereed ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            kannawad Arun Kannawadi made changes -
            Story Points 20
            yusra Yusra AlSayyad made changes -
            Sprint DRP S20-3 (Feb), DRP S20-5 (Apr) [ 1000, 1014 ] DRP S20-3 (Feb), DRP S20-5 (Apr), DRP S20-6 (May) [ 1000, 1014, 1021 ]
            kannawad Arun Kannawadi made changes -
            Epic Link DM-23741 [ 431398 ] DM-23736 [ 431392 ]
            kannawad Arun Kannawadi made changes -
            Story Points 20 21
            Hide
            sophiereed Sophie Reed added a comment -

            It would be good to see the plots the code produces here.

            Show
            sophiereed Sophie Reed added a comment - It would be good to see the plots the code produces here.
            kannawad Arun Kannawadi made changes -
            Hide
            kannawad Arun Kannawadi added a comment -

            Plot produced from running coaddAnalysis.py on tract=9697 and filter=HSC-I

            Show
            kannawad Arun Kannawadi added a comment - Plot produced from running coaddAnalysis.py on tract=9697 and filter=HSC-I
            kannawad Arun Kannawadi made changes -
            Hide
            kannawad Arun Kannawadi added a comment -

            Plot produced from running visitAnalysis.py on visit=35892, tract=9697

             

            Show
            kannawad Arun Kannawadi added a comment - Plot produced from running visitAnalysis.py on visit=35892, tract=9697  
            Hide
            kannawad Arun Kannawadi added a comment -

            All other plots for pipe_analysis are single panel plots, and I believe the standard way the text, labels are put in, doesn't like this two panel format. Barring these cosmetic issues, the essence of the content of the plot is present above.

             

            Show
            kannawad Arun Kannawadi added a comment - All other plots for pipe_analysis are single panel plots, and I believe the standard way the text, labels are put in, doesn't like this two panel format. Barring these cosmetic issues, the essence of the content of the plot is present above.  
            Hide
            sophiereed Sophie Reed added a comment -

            It would be better if the textual labels on the plot did not overlap so that they are easily legible. There is also plenty of whitespace on the plot, both within the axes and without, please could you move the legend so that it does not overlap the data points. It would also probably be better if the rerun information was at the bottom of the plot, otherwise it looks like that is relevant to the difference between panels. There is a function in fakesAnalysis that adds information to the outskirts of the plot that might be of use, or might not, but you could look at it.

            Show
            sophiereed Sophie Reed added a comment - It would be better if the textual labels on the plot did not overlap so that they are easily legible. There is also plenty of whitespace on the plot, both within the axes and without, please could you move the legend so that it does not overlap the data points. It would also probably be better if the rerun information was at the bottom of the plot, otherwise it looks like that is relevant to the difference between panels. There is a function in fakesAnalysis that adds information to the outskirts of the plot that might be of use, or might not, but you could look at it.
            yusra Yusra AlSayyad made changes -
            Epic Link DM-23736 [ 431392 ] DM-25320 [ 435710 ]
            yusra Yusra AlSayyad made changes -
            Sprint DRP S20-3 (Feb), DRP S20-5 (Apr), DRP S20-6 (May) [ 1000, 1014, 1021 ] DRP S20-3 (Feb), DRP S20-5 (Apr), DRP S20-6 (May), DRP F20-1 (June) [ 1000, 1014, 1021, 1030 ]
            kannawad Arun Kannawadi made changes -
            Hide
            kannawad Arun Kannawadi added a comment -

            The plots from the most recent version of the branch is attached here. For the sake of clarity, the different Rho statistics are plotted to two different files, instead of two panels in one figure.

            Show
            kannawad Arun Kannawadi added a comment - The plots from the most recent version of the branch is attached here. For the sake of clarity, the different Rho statistics are plotted to two different files, instead of two panels in one figure.
            kannawad Arun Kannawadi made changes -
            Link This issue is parent task of DM-25450 [ DM-25450 ]
            mschmitz Morgan Schmitz made changes -
            Reviewers Morgan Schmitz, Sophie Reed [ mschmitz, sophiereed ] Sophie Reed [ sophiereed ]
            Hide
            sophiereed Sophie Reed added a comment -

            What is the difference between the filled and empty symbols?

             

            Show
            sophiereed Sophie Reed added a comment - What is the difference between the filled and empty symbols?  
            Hide
            kannawad Arun Kannawadi added a comment -

            The filled points are positive in sign, and empty are negative. We are interested in the magnitude of the rho-statistics and the sign of the points are only secondary. So have the y-axis in symlog scale isn't particularly helpful.

            Show
            kannawad Arun Kannawadi added a comment - The filled points are positive in sign, and empty are negative. We are interested in the magnitude of the rho-statistics and the sign of the points are only secondary. So have the y-axis in symlog scale isn't particularly helpful.
            Hide
            sophiereed Sophie Reed added a comment -

            Thank you for cleaning this up, it's looking much better.

            Show
            sophiereed Sophie Reed added a comment - Thank you for cleaning this up, it's looking much better.
            sophiereed Sophie Reed made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            kannawad Arun Kannawadi made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              • Assignee:
                kannawad Arun Kannawadi
                Reporter:
                kannawad Arun Kannawadi
                Reviewers:
                Sophie Reed
                Watchers:
                Arun Kannawadi, Morgan Schmitz, Sophie Reed
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel