Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-23582

Jenkins nightly-release still fails in run-publish due to conda env name

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: jenkins
    • Labels:
      None
    • Team:
      Architecture
    • Urgent?:
      No

      Description

      Unfortunately, the DM-23565 fix was insufficient.  While it looked good from a code perspective, it appears that the environment file created in run-rebuild is not preserved for the run-publish pipeline.  Investigate how state is shared between these pipelines and see whether this environment file can be similarly shared, or else arrange for it to be re-created in run-publish.  (This will be made harder by the fact that the state does not appear to be preserved on GPFS but instead is more ephemeral.)

        Attachments

          Activity

          Hide
          gcomoretto Gabriele Comoretto [X] (Inactive) added a comment -

          I think it is safer just to provide the environment reference to run_publish and activate the corresponding environment.

          Show
          gcomoretto Gabriele Comoretto [X] (Inactive) added a comment - I think it is safer just to provide the environment reference to run_publish and activate the corresponding environment.
          Hide
          tjenness Tim Jenness added a comment -

          Or write the .env file to the stack directory tree instead of the build directory. (since surely the stack directory must exist)

          Show
          tjenness Tim Jenness added a comment - Or write the .env file to the stack directory tree instead of the build directory. (since surely the stack directory must exist)
          Hide
          ktl Kian-Tat Lim added a comment -

          It is being written to /j/snowflake/release/lsstsw/env, which seems like it should be preserved from rebuild to publish along with the rest of /j/snowflake/release/lsstsw.

          Show
          ktl Kian-Tat Lim added a comment - It is being written to /j/snowflake/release/lsstsw/env , which seems like it should be preserved from rebuild to publish along with the rest of /j/snowflake/release/lsstsw .
          Hide
          ktl Kian-Tat Lim added a comment -

          Gabriele Comoretto [X] and I would like to remove the conda environment selection from run-rebuild and run-publish, as we think they should always use the default environment.  But that is a bit tricky right now, so to get nightlies moving again I have implemented what I hope is a minimal fix, passing the (default) environment hash to the run-publish pipeline and having it be used in the invocation of envconfig instead of the build number.

          Show
          ktl Kian-Tat Lim added a comment - Gabriele Comoretto [X] and I would like to remove the conda environment selection from run-rebuild and run-publish, as we think they should always use the default environment.  But that is a bit tricky right now, so to get nightlies moving again I have implemented what I hope is a minimal fix, passing the (default) environment hash to the run-publish pipeline and having it be used in the invocation of envconfig instead of the build number.
          Hide
          gcomoretto Gabriele Comoretto [X] (Inactive) added a comment -

          The change looks good to me. 

          Not sure how we can test it.

          Show
          gcomoretto Gabriele Comoretto [X] (Inactive) added a comment - The change looks good to me.  Not sure how we can test it.
          Hide
          ktl Kian-Tat Lim added a comment -

          It ran properly for dax/release/rebuild_publish_qserv-dev.  I'm re-running nightly-release.

          Show
          ktl Kian-Tat Lim added a comment - It ran properly for dax/release/rebuild_publish_qserv-dev.  I'm re-running nightly-release.
          Hide
          ktl Kian-Tat Lim added a comment -

          nightly-release has run through the publish step, so I'm closing this.

          Show
          ktl Kian-Tat Lim added a comment - nightly-release has run through the publish step, so I'm closing this.

            People

            Assignee:
            ktl Kian-Tat Lim
            Reporter:
            ktl Kian-Tat Lim
            Reviewers:
            Gabriele Comoretto [X] (Inactive)
            Watchers:
            Adam Thornton, Frossie Economou, Gabriele Comoretto [X] (Inactive), Kian-Tat Lim, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.