Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-23583

Clean up meas_deblender

    Details

    • Type: Bug
    • Status: To Do
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: meas_deblender
    • Labels:
      None
    • Templates:
    • Story Points:
      3
    • Team:
      Data Release Production
    • Urgent?:
      No

      Description

      Yusra AlSayyad identified a lot of "scary" code in meas_deblender a while back but it was not addressed to instead focus on the development of scarlet and meas_extensions_scarlet as a replacement for meas_deblender. But there are some bug and poorly documented features that should be addressed, if for no other reason than to prevent future developers from getting confused by documentation that is incorrect. These changes are:

      • Documentation of config parameters and python docstrings needs to be clarified, as the exact purpose of many parameters and methods are obfuscated or incorrect.
      • All config parameters must exist and be propagated. For certain the parameter to turn off monotonicity doesn't exist in the Config class and clipFootprintsToNonzero is not propagated to the deblender plugins. The configs should also be investigated for other, similar inconsistencies.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              fred3m Fred Moolekamp
              Watchers:
              Fred Moolekamp
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:

                Summary Panel