Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-23651

ap_pipe calls some deprecated things

    Details

    • Story Points:
      2
    • Sprint:
      AP S20-5 (April)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      I noticed when reviewing recent ap_pipe logs that there are some deprecation warnings we should probably deal with.

      /software/lsstsw/stack_20200220/stack/miniconda3-4.7.12-984c9f7/Linux64/obs_decam/19.0.0-6-gb5bb71e+12/config/isr.py:95: FutureWarning: Config field ccdProcessor.isr.doAddDistortionModel is deprecated: Camera geometry is incorporated when reading the raw files. This option no longer is used, and will be removed after v19.
      /software/lsstsw/stack_20200220/stack/miniconda3-4.7.12-984c9f7/Linux64/ap_association/19.0.0-13-g744ec97+3/python/lsst/ap/association/mapApData.py:185: YAMLLoadWarning: calling yaml.load_all() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
      /software/lsstsw/stack_20200220/stack/miniconda3-4.7.12-984c9f7/Linux64/pex_config/19.0.0-5-g9aa49c1+1/python/lsst/pex/config/configurableField.py:150: FutureWarning: Config field ccdProcessor.isr.doAddDistortionModel is deprecated: Camera geometry is incorporated when reading the raw files. This option no longer is used, and will be removed after v19.
      /software/lsstsw/stack_20200220/stack/miniconda3-4.7.12-984c9f7/Linux64/ip_diffim/19.0.0-7-g2f7a0e4+3/python/lsst/ip/diffim/imagePsfMatch.py:785: FutureWarning: Call to deprecated method getImageF(). (Zero-argument overload is deprecated; use one that takes an ``interpStyle`` instead. To be removed after 20.0.0.)
      /software/lsstsw/stack_20200220/stack/miniconda3-4.7.12-984c9f7/Linux64/ip_diffim/19.0.0-7-g2f7a0e4+3/python/lsst/ip/diffim/imageDecorrelation.py:421: FutureWarning: Call to deprecated method setCtrX. (Use `setCtr` instead. To be removed after 20.0.0.)
      /software/lsstsw/stack_20200220/stack/miniconda3-4.7.12-984c9f7/Linux64/ip_diffim/19.0.0-7-g2f7a0e4+3/python/lsst/ip/diffim/imageDecorrelation.py:422: FutureWarning: Call to deprecated method setCtrY. (Use `setCtr` instead. To be removed after 20.0.0.)
      /software/lsstsw/stack_20200220/stack/miniconda3-4.7.12-984c9f7/Linux64/pipe_tasks/19.0.0-28-g53bcf5f6+2/python/lsst/pipe/tasks/imageDifference.py:759: FutureWarning: Call to deprecated method makeSourceCatalog. (Replaced by SourceDetectionTask.run(). Will be removed after v20.) 

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            Four of those warnings are blockers for DM-22815. Two are blockers for DM-20564. There are two YAML calls in ap_association that need to be fixed and it looks like those are being tracked in DM-18907

            Show
            tjenness Tim Jenness added a comment - Four of those warnings are blockers for DM-22815 . Two are blockers for DM-20564 . There are two YAML calls in ap_association that need to be fixed and it looks like those are being tracked in DM-18907
            Hide
            krzys Krzysztof Findeisen added a comment -

            I think I can get to this in April (subject to approval from John Swinbank, of course).

            Show
            krzys Krzysztof Findeisen added a comment - I think I can get to this in April (subject to approval from John Swinbank , of course).
            Hide
            swinbank John Swinbank added a comment -

            Let's talk about it at sprint planning. Mail coming up...

            Show
            swinbank John Swinbank added a comment - Let's talk about it at sprint planning. Mail coming up...
            Hide
            krzys Krzysztof Findeisen added a comment -

            John Swinbank, would you be willing to review this?

            ap_pipe now runs for me with no deprecation warnings. I've only tested it with DECam data, but it was easy to update the other obs packages while I was at it.

            I did not see the warnings for getImageF or makeSourceCatalog; I assume they were already fixed on another issue.

            Show
            krzys Krzysztof Findeisen added a comment - John Swinbank , would you be willing to review this? ap_pipe now runs for me with no deprecation warnings. I've only tested it with DECam data, but it was easy to update the other obs packages while I was at it. I did not see the warnings for getImageF or makeSourceCatalog ; I assume they were already fixed on another issue.
            Hide
            swinbank John Swinbank added a comment - - edited

            Changes look fine to me: thank you! Some of them are outdated and need rebasing (my fault; sorry for being slow). Assuming they still pass Jenkins when you've done that, good to merge.

            Show
            swinbank John Swinbank added a comment - - edited Changes look fine to me: thank you! Some of them are outdated and need rebasing (my fault; sorry for being slow). Assuming they still pass Jenkins when you've done that, good to merge.

              People

              • Assignee:
                krzys Krzysztof Findeisen
                Reporter:
                mrawls Meredith Rawls
                Reviewers:
                John Swinbank
                Watchers:
                Gabor Kovacs, John Swinbank, Krzysztof Findeisen, Meredith Rawls, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel