Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-2368

GaussianCentroid should set an error

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Invalid
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_base
    • Labels:
    • Team:
      Data Release Production

      Description

      According to GaussianCentroid.h in meas_base the GaussianCentroid algorithm "does not currently set an error, though it should".

        Attachments

          Issue Links

          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-1014 Detailed documentation for GaussianCentroid

          • Invalid
          is mitigated by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-13395 Drop GaussianCentroid

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-1014 Detailed documentation for GaussianCentroid

          • Invalid
          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            rhl Robert Lupton added a comment -

            It's gone:

            commit e8008769f3ed8268e5c852bf1f4faeb288f8a1b4 (origin/tickets/DM-13395)
            Author: Paul Price <price@astro.princeton.edu>
            Date: Thu Feb 1 11:57:14 2018 -0500

            remove GaussianCentroid

            Per RFC-437.

            SdssCentroid performs at least as well and is faster. GaussianCentroid
            is not valgrind-clean, and removing it will save on maintenance.

            Show
            rhl Robert Lupton added a comment - It's gone: commit e8008769f3ed8268e5c852bf1f4faeb288f8a1b4 (origin/tickets/ DM-13395 ) Author: Paul Price <price@astro.princeton.edu> Date: Thu Feb 1 11:57:14 2018 -0500 remove GaussianCentroid Per RFC-437 . SdssCentroid performs at least as well and is faster. GaussianCentroid is not valgrind-clean, and removing it will save on maintenance.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Ah! Sorry I missed that. Thanks Robert Lupton!

            Show
            swinbank John Swinbank added a comment - Ah! Sorry I missed that. Thanks Robert Lupton !

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              swinbank John Swinbank
              Watchers:
              John Swinbank, Robert Lupton
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.